Skip to content

N-04: revert on invalid BUNDLE_IDENTIFIER in GWAssetTracker #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valera-grinenko-ai wants to merge 1 commit into
base: draft-v31
Choose a base branch
from
Open

N-04: revert on invalid BUNDLE_IDENTIFIER in GWAssetTracker #2123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions l1-contracts/contracts/bridge/asset-tracker/GWAssetTracker.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import {AssetRouterBase} from "../asset-router/AssetRouterBase.sol";
import {INativeTokenVaultBase} from "../ntv/INativeTokenVaultBase.sol";
import {
ChainIdNotRegistered,
InvalidBundleIdentifier,
InvalidInteropCalldata,
InvalidMessage,
ReconstructionMismatch,
Expand Down Expand Up @@ -496,8 +497,7 @@ contract GWAssetTracker is AssetTrackerBase, IGWAssetTracker {
bytes calldata _message
) internal returns (uint256 chargeableCallCount) {
if (_message[0] != BUNDLE_IDENTIFIER) {
// This should not be possible in V31. In V31 this will be a trigger.
return 0;
revert InvalidBundleIdentifier();
}

InteropBundle memory interopBundle = abi.decode(_message[1:], (InteropBundle));
Expand Down
1 change: 1 addition & 0 deletions l1-contracts/contracts/common/L1ContractErrors.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ error IncorrectTokenAddressFromNTV(bytes32 assetId, address tokenAddress);
error InsufficientFunds(uint256 required, uint256 actual);
// 0x9bf8b9aa
error InvalidBatchNumber(uint256 provided, uint256 expected);
error InvalidBundleIdentifier();
// 0xd438e1fa
error InvalidBlockRange(uint64 batchNumber, uint64 from, uint64 to);
// 0xcbd9d2e0
Expand Down