Declare interval, disabled, and run_only_one in inputs.conf.spec by horgh · Pull Request #80 · maxmind/geoip-splunk

horgh · 2026-06-22T22:47:01Z

Add the interval, disabled, and run_only_one settings to the geoipupdate_input modular input spec so the input's supported parameters are documented. The dummy param1 is retained so the modular input type stays registered (Splunk silently ignores schemes with no custom parameter).

Summary by CodeRabbit

Documentation

Documented the interval, disabled, and run_only_one configuration parameters for the GeoIP update input, clarifying the supported settings and available configuration options.

coderabbitai · 2026-06-22T22:47:17Z

📝 Walkthrough

Walkthrough

Three previously undocumented parameters—interval (integer), disabled (boolean), and run_only_one (boolean)—are added to the geoipupdate_input://default stanza in inputs.conf.spec. A corresponding 1.1.1 entry is added to CHANGELOG.md.

Changes

Spec and Changelog Update

Layer / File(s)	Summary
`inputs.conf.spec` declarations and changelog entry `geoip/package/README/inputs.conf.spec`, `CHANGELOG.md`	Adds `interval`, `disabled`, and `run_only_one` parameter definitions to the `geoipupdate_input://default` stanza, and records the addition under a new `1.1.1` section in the changelog.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 Hop hop, the spec is now complete,
Three fields were hiding, now they meet!
interval, disabled, run_only_one too,
All tucked in the README, shiny and new.
The changelog sings version one-one-one,
A tiny doc fix — perfectly done! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and specifically describes the main change: declaring three parameters (interval, disabled, run_only_one) in the inputs.conf.spec file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch wstorey/set-spec

_{Comment @coderabbitai help to get the list of available commands.}

Add the interval, disabled, and run_only_one settings to the geoipupdate_input modular input spec so the input's supported parameters are documented. The dummy param1 is retained so the modular input type stays registered (Splunk silently ignores schemes with no custom parameter). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

gemini-code-assist

Code Review

This pull request adds the 'interval', 'disabled', and 'run_only_one' settings to 'inputs.conf.spec' and documents this change in the changelog. However, redefining these system-defined parameters in a custom spec file violates Splunk AppInspect guidelines and will cause validation failures. It is recommended to remove these declarations and update the changelog accordingly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-06-22T22:47:51Z

+interval = <integer>
+disabled = <boolean>
+run_only_one = <boolean>


Redefining system-defined parameters like interval, disabled, and run_only_one in a custom inputs.conf.spec file is a violation of Splunk AppInspect guidelines. These parameters are already defined globally by Splunk's system-level configuration specs. Including them here will cause Splunk AppInspect to fail validation with errors regarding overriding system-defined properties.\n\nIt is recommended to remove these declarations from the spec file. If you need to document them, it is best to do so in the app's README or documentation rather than the .spec file.

gemini-code-assist · 2026-06-22T22:47:51Z

+## 1.1.1
+
+* Declare the `interval`, `disabled`, and `run_only_one` settings in the
+  `geoipupdate_input` modular input's `inputs.conf.spec` so the input's
+  supported parameters are documented in the spec file.
+


If the changes to inputs.conf.spec are reverted to avoid AppInspect failures, this changelog entry should also be removed or updated accordingly.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Around line 3-8: The version 1.1.1 entry in the CHANGELOG.md file is missing a
release date or unreleased status indicator, while other versions like 1.1.0 and
1.0.0 include dates for consistency. Update the version 1.1.1 header to either
include a release date in the same format as other versions (e.g., "## 1.1.1 -
YYYY-MM-DD") if this version has been released, or add an unreleased indicator
(e.g., "## 1.1.1 (Unreleased)") if this is a planned release.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 197e3e7d-10f1-48dd-944d-141de112373e

📥 Commits

Reviewing files that changed from the base of the PR and between 40ce059 and 030d6e6.

📒 Files selected for processing (2)

CHANGELOG.md
geoip/package/README/inputs.conf.spec

coderabbitai · 2026-06-22T22:50:18Z

+## 1.1.1
+
+* Declare the `interval`, `disabled`, and `run_only_one` settings in the
+  `geoipupdate_input` modular input's `inputs.conf.spec` so the input's
+  supported parameters are documented in the spec file.
+


📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add release date or mark version 1.1.1 as unreleased.

Version 1.1.1 lacks a release date, while versions 1.1.0 and 1.0.0 both include dates. For consistency, either add a date (if released) or add an "Unreleased" label (if this is a planned release).

📝 Suggested fixes

Option 1: If released, add date

-## 1.1.1 +## 1.1.1 (2026-06-YY)

Option 2: If unreleased, clarify status

-## 1.1.1 +## Unreleased (1.1.1)

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

## 1.1.1

* Declare the `interval`, `disabled`, and `run_only_one` settings in the

`geoipupdate_input` modular input's `inputs.conf.spec` so the input's

supported parameters are documented in the spec file.

## 1.1.1 (2026-06-YY)

* Declare the `interval`, `disabled`, and `run_only_one` settings in the

`geoipupdate_input` modular input's `inputs.conf.spec` so the input's

supported parameters are documented in the spec file.

Suggested change

## 1.1.1

* Declare the `interval`, `disabled`, and `run_only_one` settings in the

`geoipupdate_input` modular input's `inputs.conf.spec` so the input's

supported parameters are documented in the spec file.

## Unreleased (1.1.1)

* Declare the `interval`, `disabled`, and `run_only_one` settings in the

`geoipupdate_input` modular input's `inputs.conf.spec` so the input's

supported parameters are documented in the spec file.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CHANGELOG.md` around lines 3 - 8, The version 1.1.1 entry in the CHANGELOG.md file is missing a release date or unreleased status indicator, while other versions like 1.1.0 and 1.0.0 include dates for consistency. Update the version 1.1.1 header to either include a release date in the same format as other versions (e.g., "## 1.1.1 - YYYY-MM-DD") if this version has been released, or add an unreleased indicator (e.g., "## 1.1.1 (Unreleased)") if this is a planned release.

horgh force-pushed the wstorey/set-spec branch from 7176979 to 030d6e6 Compare June 22, 2026 22:47

gemini-code-assist Bot reviewed Jun 22, 2026

View reviewed changes

coderabbitai Bot reviewed Jun 22, 2026

View reviewed changes

horgh mentioned this pull request Jun 23, 2026

MaxMind databases not propagated correctly within the Search Head Cluster #76

Open

oschwald approved these changes Jun 23, 2026

View reviewed changes

oschwald merged commit d3a55b3 into main Jun 23, 2026
10 checks passed

oschwald deleted the wstorey/set-spec branch June 23, 2026 14:12

This was referenced Jun 25, 2026

Declare run_only_one as a scheme argument for geoipupdate_input #84

Merged

Add scripted-input variant of the database updater #88

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Declare interval, disabled, and run_only_one in inputs.conf.spec#80

Declare interval, disabled, and run_only_one in inputs.conf.spec#80
oschwald merged 1 commit into
mainfrom
wstorey/set-spec

horgh commented Jun 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 22, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jun 22, 2026

Uh oh!

gemini-code-assist Bot Jun 22, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jun 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

horgh commented Jun 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Documentation

Uh oh!

coderabbitai Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

horgh commented Jun 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 22, 2026 •

edited

Loading