Skip to content

Declare interval, disabled, and run_only_one in inputs.conf.spec #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oschwald merged 1 commit into from
Jun 23, 2026
Merged

Declare interval, disabled, and run_only_one in inputs.conf.spec #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 1.1.1

* Declare the `interval`, `disabled`, and `run_only_one` settings in the
`geoipupdate_input` modular input's `inputs.conf.spec` so the input's
supported parameters are documented in the spec file.

Comment on lines +3 to +8

@gemini-code-assist gemini-code-assist Bot Jun 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If the changes to inputs.conf.spec are reverted to avoid AppInspect failures, this changelog entry should also be removed or updated accordingly.

Comment on lines +3 to +8

@coderabbitai coderabbitai Bot Jun 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add release date or mark version 1.1.1 as unreleased.

Version 1.1.1 lacks a release date, while versions 1.1.0 and 1.0.0 both include dates. For consistency, either add a date (if released) or add an "Unreleased" label (if this is a planned release).

📝 Suggested fixes

Option 1: If released, add date

-## 1.1.1
+## 1.1.1 (2026-06-YY)

Option 2: If unreleased, clarify status

-## 1.1.1
+## Unreleased (1.1.1)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## 1.1.1
* Declare the `interval`, `disabled`, and `run_only_one` settings in the
`geoipupdate_input` modular input's `inputs.conf.spec` so the input's
supported parameters are documented in the spec file.
## 1.1.1 (2026-06-YY)
* Declare the `interval`, `disabled`, and `run_only_one` settings in the
`geoipupdate_input` modular input's `inputs.conf.spec` so the input's
supported parameters are documented in the spec file.
Suggested change
## 1.1.1
* Declare the `interval`, `disabled`, and `run_only_one` settings in the
`geoipupdate_input` modular input's `inputs.conf.spec` so the input's
supported parameters are documented in the spec file.
## Unreleased (1.1.1)
* Declare the `interval`, `disabled`, and `run_only_one` settings in the
`geoipupdate_input` modular input's `inputs.conf.spec` so the input's
supported parameters are documented in the spec file.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CHANGELOG.md` around lines 3 - 8, The version 1.1.1 entry in the CHANGELOG.md
file is missing a release date or unreleased status indicator, while other
versions like 1.1.0 and 1.0.0 include dates for consistency. Update the version
1.1.1 header to either include a release date in the same format as other
versions (e.g., "## 1.1.1 - YYYY-MM-DD") if this version has been released, or
add an unreleased indicator (e.g., "## 1.1.1 (Unreleased)") if this is a planned
release.

## 1.1.0 (2026-04-01)

* Set `local = true` for the `geoip` search command so it runs on the search
Expand Down
3 changes: 3 additions & 0 deletions geoip/package/README/inputs.conf.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
[geoipupdate_input://default]
param1 =
interval = <integer>
disabled = <boolean>
run_only_one = <boolean>
Comment on lines +3 to +5

@gemini-code-assist gemini-code-assist Bot Jun 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Redefining system-defined parameters like interval, disabled, and run_only_one in a custom inputs.conf.spec file is a violation of Splunk AppInspect guidelines. These parameters are already defined globally by Splunk's system-level configuration specs. Including them here will cause Splunk AppInspect to fail validation with errors regarding overriding system-defined properties.\n\nIt is recommended to remove these declarations from the spec file. If you need to document them, it is best to do so in the app's README or documentation rather than the .spec file.

Loading