Release 1.1.1#81
Conversation
The previous globalConfig.json and pyproject.toml substitutions used unescaped quotes around "version", so bash stripped them and perl got the lookbehind (?<=version: "), which never matched the JSON "version": ". The globalConfig.json bump was silently a no-op. Move the substitution into a replace_version helper that passes the version via an env var (so the regex can be single-quoted, no quote escaping) and dies if the regex matched nothing, aborting the release under set -e. Use it to also bump the versions in app.manifest, build.sh, and lint.yml. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Use git push -u origin HEAD so the release script works on a fresh branch that has no upstream configured, without relying on push.autoSetupRemote. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Run ./build.sh during the release so a build failure aborts before we commit, and pass the resulting geoip-<version>.tar.gz to gh release create so it is attached at creation time. We use immutable releases, so assets cannot be added after the release exists. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 54 minutes and 42 seconds. Learn how PR review limits work. To continue reviewing without waiting, enable usage-based billing in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR bumps the app version from 1.1.0 to 1.1.1 across all versioned files ( Release 1.1.1
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 1.1.1 across configuration files, adds release documentation, and enhances the release script to automate tarball building and version replacement. The feedback suggests refining a regular expression in the release script to be more specific, preventing potential accidental matches when updating the version in the GitHub Actions workflow.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| replace_version pyproject.toml '(?<=^version = ").+?(?=")' | ||
| replace_version geoip/package/app.manifest '(?<="version": ").+?(?=")' | ||
| replace_version build.sh '(?<=--ta-version )\S+' | ||
| replace_version .github/workflows/lint.yml '(?<=geoip-).+?(?=\.tar\.gz)' |
There was a problem hiding this comment.
Using .+? in the regular expression is very generic and can lead to accidental matches if there are other files or strings in .github/workflows/lint.yml that start with geoip- and end with .tar.gz (for example, geoip-utils-1.0.0.tar.gz).\n\nConsider using a more specific pattern that only matches version strings (e.g., digits, dots, and optional pre-release characters).
| replace_version .github/workflows/lint.yml '(?<=geoip-).+?(?=\.tar\.gz)' | |
| replace_version .github/workflows/lint.yml '(?<=geoip-)[0-9a-zA-Z.-]+(?=\.tar\.gz)' |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.dev.md (1)
1-7: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd a top-level heading.
The file still violates MD041 because it starts with plain text.
♻️ Proposed fix
-How to release: +# How to release🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.dev.md` around lines 1 - 7, The README.dev.md file violates the MD041 markdown linting rule because it starts with plain text instead of a top-level heading. Add a top-level heading (using # syntax) at the very beginning of the file, before the "How to release:" line. This heading should clearly describe the file's purpose or content.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@README.dev.md`:
- Around line 1-7: The README.dev.md file violates the MD041 markdown linting
rule because it starts with plain text instead of a top-level heading. Add a
top-level heading (using # syntax) at the very beginning of the file, before the
"How to release:" line. This heading should clearly describe the file's purpose
or content.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: bf7a7feb-f4ef-4e94-8311-3779000a8d6e
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
.github/workflows/lint.ymlCHANGELOG.mdREADME.dev.mdbuild.shdev-bin/release.shgeoip/globalConfig.jsongeoip/package/app.manifestpyproject.toml
Summary by CodeRabbit