Skip to content

Release 1.1.1#81

Merged
oschwald merged 8 commits into
mainfrom
wstorey/release
Jun 23, 2026
Merged

Release 1.1.1#81
oschwald merged 8 commits into
mainfrom
wstorey/release

Conversation

@horgh

@horgh horgh commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Version updated to 1.1.1 across project configurations and build artifacts.
    • Release process documentation and automation enhancements implemented.
    • CHANGELOG updated with release date (2026-06-23).

horgh and others added 7 commits June 23, 2026 21:20
The previous globalConfig.json and pyproject.toml substitutions used
unescaped quotes around "version", so bash stripped them and perl got the
lookbehind (?<=version: "), which never matched the JSON "version": ".
The globalConfig.json bump was silently a no-op.

Move the substitution into a replace_version helper that passes the version
via an env var (so the regex can be single-quoted, no quote escaping) and
dies if the regex matched nothing, aborting the release under set -e. Use it
to also bump the versions in app.manifest, build.sh, and lint.yml.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Use git push -u origin HEAD so the release script works on a fresh branch
that has no upstream configured, without relying on push.autoSetupRemote.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Run ./build.sh during the release so a build failure aborts before we commit,
and pass the resulting geoip-<version>.tar.gz to gh release create so it is
attached at creation time. We use immutable releases, so assets cannot be
added after the release exists.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@horgh, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 54 minutes and 42 seconds. Learn how PR review limits work.

To continue reviewing without waiting, enable usage-based billing in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 71fa1316-37bb-4a28-9cfe-02d5adbf1ee1

📥 Commits

Reviewing files that changed from the base of the PR and between 1b7a04d and d12dcf4.

📒 Files selected for processing (1)
  • README.dev.md
📝 Walkthrough

Walkthrough

The PR bumps the app version from 1.1.0 to 1.1.1 across all versioned files (globalConfig.json, app.manifest, pyproject.toml, build.sh, lint workflow) and updates CHANGELOG.md with the release date. It also enhances dev-bin/release.sh with a replace_version() helper, tarball existence verification, test execution, and attaches the built tarball as a GitHub release asset.

Release 1.1.1

Layer / File(s) Summary
Release script: replace_version helper, tarball check, and asset upload
dev-bin/release.sh, README.dev.md
Adds replace_version(file, regex) to perform validated in-place Perl substitutions. Extends the release workflow to enforce a clean git state, run tests, call ./build.sh, verify the expected tarball exists, push with git push -u origin HEAD, and attach the tarball to the GitHub release. Adds a "How to release" checklist to README.dev.md.
Version bump to 1.1.1
geoip/globalConfig.json, geoip/package/app.manifest, pyproject.toml, build.sh, .github/workflows/lint.yml, CHANGELOG.md
Bumps meta.version, info.id.version, [project].version, --ta-version, and the AppInspect tarball reference from 1.1.0 to 1.1.1. Adds the (2026-06-23) release date to the CHANGELOG heading.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 A hop, a skip, the version ticks,
From one-one-zero to one-one-one it flicks.
The release script now checks the tar,
Attaches it to GitHub like a star.
The bunny stamps the date with glee—
(2026-06-23) for all to see! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Release 1.1.1' directly and accurately summarizes the main objective of the changeset, which is to release version 1.1.1 across all version strings and documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch wstorey/release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version to 1.1.1 across configuration files, adds release documentation, and enhances the release script to automate tarball building and version replacement. The feedback suggests refining a regular expression in the release script to be more specific, preventing potential accidental matches when updating the version in the GitHub Actions workflow.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dev-bin/release.sh
replace_version pyproject.toml '(?<=^version = ").+?(?=")'
replace_version geoip/package/app.manifest '(?<="version": ").+?(?=")'
replace_version build.sh '(?<=--ta-version )\S+'
replace_version .github/workflows/lint.yml '(?<=geoip-).+?(?=\.tar\.gz)'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using .+? in the regular expression is very generic and can lead to accidental matches if there are other files or strings in .github/workflows/lint.yml that start with geoip- and end with .tar.gz (for example, geoip-utils-1.0.0.tar.gz).\n\nConsider using a more specific pattern that only matches version strings (e.g., digits, dots, and optional pre-release characters).

Suggested change
replace_version .github/workflows/lint.yml '(?<=geoip-).+?(?=\.tar\.gz)'
replace_version .github/workflows/lint.yml '(?<=geoip-)[0-9a-zA-Z.-]+(?=\.tar\.gz)'

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
README.dev.md (1)

1-7: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add a top-level heading.

The file still violates MD041 because it starts with plain text.

♻️ Proposed fix
-How to release:
+# How to release
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.dev.md` around lines 1 - 7, The README.dev.md file violates the MD041
markdown linting rule because it starts with plain text instead of a top-level
heading. Add a top-level heading (using # syntax) at the very beginning of the
file, before the "How to release:" line. This heading should clearly describe
the file's purpose or content.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@README.dev.md`:
- Around line 1-7: The README.dev.md file violates the MD041 markdown linting
rule because it starts with plain text instead of a top-level heading. Add a
top-level heading (using # syntax) at the very beginning of the file, before the
"How to release:" line. This heading should clearly describe the file's purpose
or content.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bf7a7feb-f4ef-4e94-8311-3779000a8d6e

📥 Commits

Reviewing files that changed from the base of the PR and between d3a55b3 and 1b7a04d.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • .github/workflows/lint.yml
  • CHANGELOG.md
  • README.dev.md
  • build.sh
  • dev-bin/release.sh
  • geoip/globalConfig.json
  • geoip/package/app.manifest
  • pyproject.toml

@oschwald oschwald merged commit 3b45023 into main Jun 23, 2026
10 checks passed
@oschwald oschwald deleted the wstorey/release branch June 23, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants