-
Notifications
You must be signed in to change notification settings - Fork 0
Release 1.1.1 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 1.1.1 #81
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cb0fcb3
Expand changelog entry
horgh 7e5d8db
Set release date for 1.1.1
horgh cc002ad
Bump versions via a replace_version helper that fails on no-match
horgh 483fe56
Set upstream when pushing the release branch
horgh ba56a7b
Update for v1.1.1
horgh 055b1cb
Build and attach the tarball when creating a release
horgh 1b7a04d
Add release instructions
horgh d12dcf4
Add note about release visibility
horgh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| How to release: | ||
|
|
||
| * Set a date in the changelog and commit | ||
| * Run dev-bin/release.sh | ||
| * dev-bin/release.sh should create the tarball e.g. geoip-1.2.3.tar.gz | ||
| * Create a new release on Splunkbase using the tarball | ||
| * Remember to set the release visible and as the default version in | ||
| Splunkbase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| "id": { | ||
| "group": null, | ||
| "name": "geoip", | ||
| "version": "1.1.0" | ||
| "version": "1.1.1" | ||
| }, | ||
| "author": [ | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
.+?in the regular expression is very generic and can lead to accidental matches if there are other files or strings in.github/workflows/lint.ymlthat start withgeoip-and end with.tar.gz(for example,geoip-utils-1.0.0.tar.gz).\n\nConsider using a more specific pattern that only matches version strings (e.g., digits, dots, and optional pre-release characters).