fix: GDB stub reading wrong code for vCont packet - #2388
Merged
Conversation
Member
|
The current code does seem to contain a mistake, please handle it so that only the correct behaviour is accepted. It was previously not spotted because gdb uses |
Contributor
Author
|
Sounds great, will change accordingly. |
Dionicio3
pushed a commit
to Dionicio3/melonDS
that referenced
this pull request
Oct 21, 2025
* fix: GDB stub reading wrong code for vCont packet * Implementation did contain bug, fixup
Zection6V
pushed a commit
to ag-advania/melonPrimeDS
that referenced
this pull request
Aug 13, 2026
* fix: GDB stub reading wrong code for vCont packet * Implementation did contain bug, fixup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was attempting to use the gdb stub with lldb (in its gdb-remote mode) and noticed that the debugging session was always abruptly terminated whenever attempting to step or continue after a breakpoint was hit. It turns out that lldb sends the
vContpacket for these actions, e.g.vCont;s:1. This is the correct format for this command as seen in the gdb documentation here -- specifically, it indicates continue, step, thread 1.However, the current gdb stub implementation was reading the
;as the continue action code, assuming it was invalid, and then throwing an error. To me, this just seems like it should have never worked, but I'm also not super familiar with gdb's internals so I've fixed the issue without introducing a breaking change.