Skip to content

fix: GDB stub reading wrong code for vCont packet #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RSDuck merged 2 commits into from
Sep 3, 2025
Merged

fix: GDB stub reading wrong code for vCont packet #2388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8d2d12
fix: GDB stub reading wrong code for vCont packet
jonko0493 Jul 31, 2025
973969e
Implementation did contain bug, fixup
jonko0493 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/debug/GdbCmds.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,14 +886,14 @@ ExecResult GdbStub::Handle_v_MustReplyEmpty(GdbStub* stub, const u8* cmd, ssize_

ExecResult GdbStub::Handle_v_Cont(GdbStub* stub, const u8* cmd, ssize_t len)
{
if (len < 1)
if (len < 2)
{
printf("insufficient length");
stub->RespStr("E01");
return ExecResult::Ok;
}

switch (cmd[0])
switch (cmd[1])
{
case 'c':
stub->RespStr("OK");
Expand All @@ -905,7 +905,7 @@ ExecResult GdbStub::Handle_v_Cont(GdbStub* stub, const u8* cmd, ssize_t len)
stub->RespStr("OK");
return ExecResult::MustBreak;
default:
printf("invalid continue %c %s\n", cmd[0], cmd);
printf("invalid continue %c %s\n", cmd[1], cmd);
stub->RespStr("E01");
return ExecResult::Ok;
}
Expand Down
Loading