fix(dependencies:python): Use python{vernum}_d.lib in MSVC debug builds - #14445
Open
zicowarn wants to merge 2 commits into
Open
fix(dependencies:python): Use python{vernum}_d.lib in MSVC debug builds#14445zicowarn wants to merge 2 commits into
zicowarn wants to merge 2 commits into
Conversation
Fixes incorrect linking to Python release libraries (python313.lib) when building debug targets with MSVC on Windows. This ensures compatibility with debug Python interpreters (e.g. python_d.exe) and resolves runtime crashes. Details: - Modified `get_windows_link_args` in `dependencies/python.py` to select debug libraries based on build type and Python library suffix (_d.dll). - Added debug logging to validate library selection. Fixes: mesonbuild#14429
Contributor
|
maybe you can squash the commit Fix a writing mistake with the previous one. Do you think you could create a unit test to validate this fix ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect linking to Python release libraries (python313.lib) when building debug targets with MSVC on Windows. This ensures compatibility with debug Python interpreters (e.g. python_d.exe) and resolves runtime crashes.
Details:
get_windows_link_argsindependencies/python.pyto select debug libraries based on build type and Python library suffix (_d.dll).Fixes: #14429