Skip to content

fix(dependencies:python): Use python{vernum}_d.lib in MSVC debug builds #14445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zicowarn wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −3
Open

fix(dependencies:python): Use python{vernum}_d.lib in MSVC debug builds #14445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bed2b4
fix(dependencies:python): Use python{vernum}_d.lib in MSVC debug builds
zicowarn Apr 3, 2025
3b0a2cf
Fix a writing mistake
zicowarn Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions mesonbuild/dependencies/python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,16 @@ def get_windows_link_args(self, limited_api: bool) -> T.Optional[T.List[str]]:
else:
libpath = Path(f'python{vernum}.dll')
else:
if self.is_freethreaded:
libpath = Path('libs') / f'python{vernum}t.lib'
library = self.variables.get('LIBRARY', '')
base_name, ext = os.path.splitext(library)
if ext.lower() == '.dll':
libpath = Path('libs') / f'{base_name}.lib'
else:
libpath = Path('libs') / f'python{vernum}.lib'
if self.is_freethreaded:
libpath = Path('libs') / f'python{vernum}t.lib'
else:
libpath = Path('libs') / f'python{vernum}.lib'
mlog.debug("Using python static library: {!r}".format(str(libpath)))
# For a debug build, pyconfig.h may force linking with
# pythonX_d.lib (see meson#10776). This cannot be avoided
# and won't work unless we also have a debug build of
Expand Down