Make AC recompute test topology-robust#490
Merged
Merged
Conversation
aditvenk
added a commit
that referenced
this pull request
Jun 12, 2026
Accept MUST_RECOMPUTE nodes carrying AutoParallel's AC graph id, since those are AP-owned FSDP recompute tags and may include wait_tensor nodes depending on the selected sharding strategy. Authored with Claude. stack-info: PR: #490, branch: aditvenk/stack/2
aditvenk
force-pushed
the
aditvenk/stack/2
branch
from
404b4ef to
c0b206e
Compare
aditvenk
force-pushed
the
aditvenk/stack/1
branch
from
250e8ae to
58f9494
Compare
meta-cla
Bot
added
the
CLA Signed
This was referenced Jun 15, 2026
fmassa
approved these changes
Jun 15, 2026
| @@ -309,7 +309,10 @@ def input_fn(): | |||
| def test_ac_joint_pass_marks_recomputable_nodes(device_mesh_1d): | |||
Contributor
There was a problem hiding this comment.
Another alternative would be to wrap the tests with apply_cuda_patches
autoparallel/tests/conftest.py
Line 36 in da99589
as this would make sure that tests assume the specific GPU arch.
Accept MUST_RECOMPUTE nodes carrying AutoParallel's AC graph id, since those are AP-owned FSDP recompute tags and may include wait_tensor nodes depending on the selected sharding strategy. Authored with Claude. stack-info: PR: #490, branch: aditvenk/stack/2
aditvenk
force-pushed
the
aditvenk/stack/2
branch
from
c0b206e to
bcca001
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Make AC recompute test topology-robust
Accept MUST_RECOMPUTE nodes carrying AutoParallel's AC graph id, since those are AP-owned FSDP recompute tags and may include wait_tensor nodes depending on the selected sharding strategy.
Authored with Claude.