Skip to content

Use upstream DTensor reshape strategy#503

Closed
aditvenk wants to merge 1 commit into
aditvenk/stack/14from
aditvenk/stack/15
Closed

Use upstream DTensor reshape strategy#503
aditvenk wants to merge 1 commit into
aditvenk/stack/14from
aditvenk/stack/15

Conversation

@fmassa fmassa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

AutoParallel's reshape override only removed a duplicate strategy, and the placement-options pipeline already deduplicates strategies after using PyTorch's registered reshape strategy.

Authored with Claude.

stack-info: PR: #503, branch: aditvenk/stack/15
@aditvenk aditvenk marked this pull request as draft June 15, 2026 16:27
@aditvenk aditvenk changed the base branch from aditvenk/stack/14 to main June 15, 2026 16:27
@aditvenk aditvenk force-pushed the aditvenk/stack/15 branch from 7351b6d to a208fdc Compare June 15, 2026 16:27
@aditvenk aditvenk changed the base branch from main to aditvenk/stack/14 June 15, 2026 16:28
@aditvenk aditvenk marked this pull request as ready for review June 15, 2026 16:28
@aditvenk

Copy link
Copy Markdown
Contributor Author

closing in favor of #505

@aditvenk aditvenk closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants