Make OpenIdAuthenticationMapper.createAuthenticationResponse reactive… - #1063
Closed
maccuaa wants to merge 0 commit into
Closed
Make OpenIdAuthenticationMapper.createAuthenticationResponse reactive…#1063maccuaa wants to merge 0 commit into
maccuaa wants to merge 0 commit into
Conversation
|
|
sdelamo
added
the
status: next major version
Member
|
@maccuaa we will have to do such changes in the next mayor version of Micronaut Security since this is a breaking change. |
Contributor
Author
|
@sdelamo No worries, I figured as much. |
Contributor
Author
|
I accidentally created this PR from the master branch in my fork which makes it difficult to sync master to create new PRs. I created a new branch with these commits and opened a new PR #1217. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the OpenIdAuthenticationMapper.createAuthenticationResponse interface method reactive. This brings the interface in line with the OauthAuthenticationMapper. createAuthenticationResponse interface method.
This will allow developers to make non-blocking API calls in the AuthenticationMapper.
Fixes #927