Skip to content

BREAKS: Reactive create authentication response - #1217

Merged
sdelamo merged 5 commits into
micronaut-projects:masterfrom
maccuaa:reactive-createAuthenticationResponse
Apr 27, 2023
Merged

BREAKS: Reactive create authentication response#1217
sdelamo merged 5 commits into
micronaut-projects:masterfrom
maccuaa:reactive-createAuthenticationResponse

Conversation

@maccuaa

@maccuaa maccuaa commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Re-opening PR #1063 (I accidentally opened that PR from master instead of creating a new branch)

Make the OpenIdAuthenticationMapper.createAuthenticationResponse interface method reactive. This brings the interface in line with the OauthAuthenticationMapper. createAuthenticationResponse interface method.

This will allow developers to make non-blocking API calls in the AuthenticationMapper.

Fixes #927

@maccuaa

maccuaa commented Mar 27, 2023

Copy link
Copy Markdown
Contributor Author

@sdelamo I see Micronaut Security 4.0.0-M1 was released. Any chance this PR can get merged to be included in the 4.0 release? The previous PR was targeted at the 4.0 release since its a breaking change - #1063 (comment)

sdelamo added a commit that referenced this pull request Mar 29, 2023
sdelamo added a commit that referenced this pull request Mar 29, 2023
sdelamo added a commit that referenced this pull request Mar 29, 2023
@sdelamo

sdelamo commented Apr 11, 2023

Copy link
Copy Markdown
Member

@sdelamo I see Micronaut Security 4.0.0-M1 was released. Any chance this PR can get merged to be included in the 4.0 release? The previous PR was targeted at the 4.0 release since its a breaking change - #1063 (comment)

Yes, we need a milestone of security to release a milestone of the framework but there will be additional releases of Micronaut Security and they will include breaking changes.

@sdelamo sdelamo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a section to breaks.adoc explaining the breaking change?

@sdelamo sdelamo added this to the 4.0.0 milestone Apr 20, 2023
@sdelamo sdelamo changed the title Reactive create authentication response BREAKS: Reactive create authentication response Apr 20, 2023
@maccuaa

maccuaa commented Apr 21, 2023

Copy link
Copy Markdown
Contributor Author

Please, add a section to breaks.adoc explaining the breaking change?

Done.

@sdelamo
sdelamo merged commit a97aaf8 into micronaut-projects:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Make OpenIdAuthenticationMapper.createAuthenticationResponse reactive

2 participants