BREAKS: Reactive create authentication response - #1217
Conversation
|
@sdelamo I see Micronaut Security 4.0.0-M1 was released. Any chance this PR can get merged to be included in the 4.0 release? The previous PR was targeted at the 4.0 release since its a breaking change - #1063 (comment) |
Yes, we need a milestone of security to release a milestone of the framework but there will be additional releases of Micronaut Security and they will include breaking changes. |
sdelamo
left a comment
There was a problem hiding this comment.
Please, add a section to breaks.adoc explaining the breaking change?
…rity into reactive-createAuthenticationResponse
Done. |
Re-opening PR #1063 (I accidentally opened that PR from master instead of creating a new branch)
Make the OpenIdAuthenticationMapper.createAuthenticationResponse interface method reactive. This brings the interface in line with the OauthAuthenticationMapper. createAuthenticationResponse interface method.
This will allow developers to make non-blocking API calls in the AuthenticationMapper.
Fixes #927