More silo enlightenment#5220
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5220 +/- ##
==========================================
- Coverage 86.74% 85.79% -0.96%
==========================================
Files 59 59
Lines 18330 18330
==========================================
- Hits 15901 15726 -175
- Misses 2429 2604 +175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Can you please add a few more details about what this does / why it is needed (or link to a bug with those details if one exists)? |
anrossi
reviewed
Jul 2, 2025
nibanks
reviewed
Jul 6, 2025
mtfriesen
previously approved these changes
Jul 7, 2025
anrossi
previously approved these changes
Jul 7, 2025
added 2 commits
July 8, 2025 00:19
mtfriesen
approved these changes
Jul 8, 2025
nibanks
approved these changes
Jul 8, 2025
csujedihy
enabled auto-merge (squash)
July 9, 2025 00:31
csujedihy
pushed a commit
that referenced
this pull request
Jul 10, 2025
Attach to the right silo when uninitializing a connection. Otherwise, the security context could be freed in a silo that's not where the context was allocated.
This was referenced Jul 10, 2025
csujedihy
pushed a commit
that referenced
this pull request
Jul 14, 2025
csujedihy
pushed a commit
that referenced
this pull request
Jul 14, 2025
#5220 Attach to the right silo when uninitializing a connection. Otherwise, the security context could be freed in a silo that's not where the context was allocated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attach to the right silo when uninitializing a connection. Otherwise, the security context could be freed in a silo that's not where the context was allocated.
Testing
CI and local testing
Documentation
N/A