fix(ci): run perf tests only after E2E passes - #2185
Merged
Conversation
Gate perf-test-basic and perf-test-advanced on the e2e job so they don't spin up clusters when the E2E suite is already failing. Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
Quang Nguyen (nddq)
requested review from
Camryn Lee (camrynl) and
Ritwik Ranjan (ritwikranjan)
April 13, 2026 14:35
ibezrukavyi
approved these changes
Apr 13, 2026
Quang Nguyen (nddq)
enabled auto-merge
April 13, 2026 14:39
Retina Code Coverage ReportTotal coverage no change |
Laksh (lakshk98)
pushed a commit
to lakshk98/retina
that referenced
this pull request
Aug 4, 2026
# Description Currently `perf-test-basic` and `perf-test-advanced` in `images.yaml` run in parallel with the `e2e` job. If E2E is already failing, both perf jobs still spin up AKS clusters, wasting ~2 hours of compute and 2 additional resource groups. This adds `e2e` to the `needs` list for both perf jobs so they only run after E2E passes. ## Related Issue N/A ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/Contributing/overview). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Workflow-only change. Verified YAML syntax is correct. ## Additional Notes N/A Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
Laksh (lakshk98)
pushed a commit
to lakshk98/retina
that referenced
this pull request
Aug 4, 2026
# Description Currently `perf-test-basic` and `perf-test-advanced` in `images.yaml` run in parallel with the `e2e` job. If E2E is already failing, both perf jobs still spin up AKS clusters, wasting ~2 hours of compute and 2 additional resource groups. This adds `e2e` to the `needs` list for both perf jobs so they only run after E2E passes. ## Related Issue N/A ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/Contributing/overview). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Workflow-only change. Verified YAML syntax is correct. ## Additional Notes N/A Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently
perf-test-basicandperf-test-advancedinimages.yamlrun in parallel with thee2ejob. If E2E is already failing, both perf jobs still spin up AKS clusters, wasting ~2 hours of compute and 2 additional resource groups.This adds
e2eto theneedslist for both perf jobs so they only run after E2E passes.Related Issue
N/A
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Workflow-only change. Verified YAML syntax is correct.
Additional Notes
N/A