Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Sessions E2E GitHub Actions workflow trigger configuration to avoid unwanted notification emails while still allowing the workflow to be run manually.
Changes:
- Switch the workflow to be manually triggered via
workflow_dispatch. - Add an explanatory comment about why the workflow trigger is configured this way.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/sessions-e2e.yml |
Enables manual-only triggering for the Sessions E2E workflow to prevent unwanted notifications. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
| # - 'scripts/code-sessions-web.*' | ||
|
|
||
| # just commenting "on" property causes emails to be sent to everyone | ||
| on: workflow_dispatch |
There was a problem hiding this comment.
For consistency with other workflows (e.g. .github/workflows/copilot-setup-steps.yml), consider using the block mapping form for triggers (on: with an indented workflow_dispatch: key) instead of the scalar shorthand. This also makes it easier to add additional triggers later without rewriting the section.
| on: workflow_dispatch | |
| on: | |
| workflow_dispatch: |
| # - 'src/vs/sessions/**' | ||
| # - 'scripts/code-sessions-web.*' | ||
|
|
||
| # just commenting "on" property causes emails to be sent to everyone |
There was a problem hiding this comment.
The comment about commenting out the on property causing emails to be sent is a bit ambiguous and may be hard for future maintainers to interpret. Consider rewording it to describe the specific failure mode (or linking to the relevant issue/incident) so it’s clear why this workflow is workflow_dispatch-only.
| # just commenting "on" property causes emails to be sent to everyone | |
| # Keep this workflow manual-only. Re-enabling the pull_request trigger above | |
| # caused GitHub Actions notification emails to be sent broadly for those runs. |
Fix for email notifications about workflow not running