Skip to content

Sessions test on property#309218

Open
osortega wants to merge 1 commit intomainfrom
osortega/chilly-primate
Open

Sessions test on property#309218
osortega wants to merge 1 commit intomainfrom
osortega/chilly-primate

Conversation

@osortega
Copy link
Copy Markdown
Contributor

Fix for email notifications about workflow not running

Copilot AI review requested due to automatic review settings April 11, 2026 18:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Sessions E2E GitHub Actions workflow trigger configuration to avoid unwanted notification emails while still allowing the workflow to be run manually.

Changes:

  • Switch the workflow to be manually triggered via workflow_dispatch.
  • Add an explanatory comment about why the workflow trigger is configured this way.
Show a summary per file
File Description
.github/workflows/sessions-e2e.yml Enables manual-only triggering for the Sessions E2E workflow to prevent unwanted notifications.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 2

# - 'scripts/code-sessions-web.*'

# just commenting "on" property causes emails to be sent to everyone
on: workflow_dispatch
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other workflows (e.g. .github/workflows/copilot-setup-steps.yml), consider using the block mapping form for triggers (on: with an indented workflow_dispatch: key) instead of the scalar shorthand. This also makes it easier to add additional triggers later without rewriting the section.

Suggested change
on: workflow_dispatch
on:
workflow_dispatch:

Copilot uses AI. Check for mistakes.
# - 'src/vs/sessions/**'
# - 'scripts/code-sessions-web.*'

# just commenting "on" property causes emails to be sent to everyone
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment about commenting out the on property causing emails to be sent is a bit ambiguous and may be hard for future maintainers to interpret. Consider rewording it to describe the specific failure mode (or linking to the relevant issue/incident) so it’s clear why this workflow is workflow_dispatch-only.

Suggested change
# just commenting "on" property causes emails to be sent to everyone
# Keep this workflow manual-only. Re-enabling the pull_request trigger above
# caused GitHub Actions notification emails to be sent broadly for those runs.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants