Skip to content

Sessions test on property #309218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osortega wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

Sessions test on property #309218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/sessions-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ name: Sessions E2E Tests
# - 'src/vs/sessions/**'
# - 'scripts/code-sessions-web.*'

# just commenting "on" property causes emails to be sent to everyone
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment about commenting out the on property causing emails to be sent is a bit ambiguous and may be hard for future maintainers to interpret. Consider rewording it to describe the specific failure mode (or linking to the relevant issue/incident) so it’s clear why this workflow is workflow_dispatch-only.

Suggested change
# just commenting "on" property causes emails to be sent to everyone
# Keep this workflow manual-only. Re-enabling the pull_request trigger above
# caused GitHub Actions notification emails to be sent broadly for those runs.

Copilot uses AI. Check for mistakes.
on: workflow_dispatch
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other workflows (e.g. .github/workflows/copilot-setup-steps.yml), consider using the block mapping form for triggers (on: with an indented workflow_dispatch: key) instead of the scalar shorthand. This also makes it easier to add additional triggers later without rewriting the section.

Suggested change
on: workflow_dispatch
on:
workflow_dispatch:

Copilot uses AI. Check for mistakes.

permissions:
contents: read

Expand Down
Loading