Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the build hygiene filters and introduces a new macOS provisioning profile under build/darwin, seemingly to address build/hygiene failures caused by provisioning profile files and generated extension outputs.
Changes:
- Exclude
*.provisionprofilefiles from the unicode and copyright hygiene checks. - Exclude
extensions/mermaid-chat-features/chat-webview-out/**from the copyright hygiene check. - Add
build/darwin/distribution.provisionprofileto the repository.
Show a summary per file
| File | Description |
|---|---|
| build/filters.ts | Updates hygiene filter globs to exclude provisioning profiles and a generated webview output directory. |
| build/darwin/distribution.provisionprofile | Adds a macOS provisioning profile file to the repo. |
Copilot's findings
- Files reviewed: 1/2 changed files
- Comments generated: 1
Comment on lines
45
to
49
| '!**/*.{d.ts,json,md}', | ||
| '!**/*.mp3', | ||
| '!**/*.tiff', | ||
| '!**/*.provisionprofile', | ||
|
|
There was a problem hiding this comment.
The hygiene pipeline runs the indentation check after the unicode stage, and *.provisionprofile files are still included in indentationFilter. If this provisioning profile is kept in-repo, it likely needs to be excluded from indentationFilter (or from all) as well; otherwise build/hygiene.ts may still fail on indentation for this file type even though it’s excluded from unicode/copyright checks.
rebornix
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.