Skip to content

fix build #309224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaomoreno merged 1 commit into from
Apr 11, 2026
+3 −0
Merged

fix build #309224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added build/darwin/distribution.provisionprofile
View file
Open in desktop
Binary file not shown.
3 changes: 3 additions & 0 deletions build/filters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export const unicodeFilter = Object.freeze<string[]>([
'!**/*.{d.ts,json,md}',
'!**/*.mp3',
'!**/*.tiff',
'!**/*.provisionprofile',

Comment on lines 45 to 49
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hygiene pipeline runs the indentation check after the unicode stage, and *.provisionprofile files are still included in indentationFilter. If this provisioning profile is kept in-repo, it likely needs to be excluded from indentationFilter (or from all) as well; otherwise build/hygiene.ts may still fail on indentation for this file type even though it’s excluded from unicode/copyright checks.

Copilot uses AI. Check for mistakes.
'!build/win32/**',
'!extensions/markdown-language-features/notebook-out/*.js',
Expand Down Expand Up @@ -184,6 +185,7 @@ export const copyrightFilter = Object.freeze<string[]>([
'!**/*.js.map',
'!**/*.wasm',
'!**/*.tiff',
'!**/*.provisionprofile',
'!build/**/*.init',
'!build/darwin/patch-dmg.py',
'!build/linux/libcxx-fetcher.*',
Expand All @@ -201,6 +203,7 @@ export const copyrightFilter = Object.freeze<string[]>([
'!extensions/html-language-features/server/src/modes/typescript/*',
'!extensions/*/server/bin/*',
'!src/vs/workbench/contrib/terminal/common/scripts/psreadline/**',
'!extensions/mermaid-chat-features/chat-webview-out/**',

// extensions/copilot has its own code style
'!extensions/copilot/**',
Expand Down
Loading