fix: drop use_fuzzy_matching from tap_on MCP schema#3181
Draft
fix: drop use_fuzzy_matching from tap_on MCP schema#3181
Conversation
All the flag did was decide whether to wrap text / id with .*...* before building the ElementSelector. The other fields on the schema (text, id, index, enabled, checked, focused, selected) map 1:1 to YAML selector keys, but use_fuzzy_matching has no YAML equivalent. When the model generated flow files instead of calling the tool, it copied the flag into the tapOn: block and produced invalid YAML. Remove the parameter and always wrap text / id with the fuzzy regex. Behavior is unchanged for any caller that used the default (true), and there's no MCP-only key for the model to leak into flows. Fixes MA-4007
Contributor
This gives me some concern that matching will be worse for shorter strings. Most uses of text and ID selectors are exact strings, not wrapped in wildcards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tap_onhad ause_fuzzy_matchingboolean parameter. All it did was decide whether to wrap thetext/idvalue in.*...*before building theElementSelector(default wastrue).The other fields on the schema (
text,id,index,enabled,checked,focused,selected) are all real YAML selector keys.use_fuzzy_matchingwas the odd one out, with no YAML equivalent. When the model generates flow files instead of calling the tool live, it copies the flag into thetapOn:block alongside the valid keys and produces invalid YAML.Fix
Remove the parameter and always wrap
textandidwith.*escapeRegex(...).*. Behavior is unchanged for any caller that used the default (true), and there is no MCP-only key left for the model to leak into flows.The rare "exact regex pass-through" case is still recoverable via
run_flowwith raw YAML.Fixes MA-4007.