Skip to content

fix: drop use_fuzzy_matching from tap_on MCP schema #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pedro18x wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −7
Draft

fix: drop use_fuzzy_matching from tap_on MCP schema #3181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions maestro-cli/src/main/java/maestro/cli/mcp/tools/TapOnTool.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ object TapOnTool {
put("type", "integer")
put("description", "0-based index if multiple elements match the same criteria")
}
putJsonObject("use_fuzzy_matching") {
put("type", "boolean")
put("description", "Whether to use fuzzy/partial text matching (true, default) or exact regex matching (false)")
}
putJsonObject("enabled") {
put("type", "boolean")
put("description", "If true, only match enabled elements. If false, only match disabled elements. Omit this field to match regardless of enabled state.")
Expand All @@ -64,7 +60,6 @@ object TapOnTool {
val text = request.arguments["text"]?.jsonPrimitive?.content
val id = request.arguments["id"]?.jsonPrimitive?.content
val index = request.arguments["index"]?.jsonPrimitive?.intOrNull
val useFuzzyMatching = request.arguments["use_fuzzy_matching"]?.jsonPrimitive?.booleanOrNull ?: true
val enabled = request.arguments["enabled"]?.jsonPrimitive?.booleanOrNull
val checked = request.arguments["checked"]?.jsonPrimitive?.booleanOrNull
val focused = request.arguments["focused"]?.jsonPrimitive?.booleanOrNull
Expand Down Expand Up @@ -98,8 +93,8 @@ object TapOnTool {
}

val elementSelector = ElementSelector(
textRegex = if (useFuzzyMatching && text != null) ".*${escapeRegex(text)}.*" else text,
idRegex = if (useFuzzyMatching && id != null) ".*${escapeRegex(id)}.*" else id,
textRegex = text?.let { ".*${escapeRegex(it)}.*" },
idRegex = id?.let { ".*${escapeRegex(it)}.*" },
index = index?.toString(),
enabled = enabled,
checked = checked,
Expand Down
Loading