Removal of Mercury and Numeric version schemes, refactoring#1212
Closed
andrzejj0 wants to merge 2 commits intomojohaus:masterfrom
Closed
Removal of Mercury and Numeric version schemes, refactoring#1212andrzejj0 wants to merge 2 commits intomojohaus:masterfrom
andrzejj0 wants to merge 2 commits intomojohaus:masterfrom
Conversation
Member
|
great, as it is next big change I will try to review it in next weekend |
Contributor
Author
|
Please feel free to invite other reviewers. Maybe Hervé or Tamas? |
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| * under the License.T |
Member
|
can you split for smaller one ... eg, looks like can be done separatly
|
Contributor
Author
Created a PR including only those two, but it's still quite sizeable mostly due to the fact that we're refactoring a key part of this whole plugin -- even though the change is small. |
86fd814 to
257dc2c
Compare
44167a1 to
37f81eb
Compare
37f81eb to
f59555a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed Numeric and Mercury version schemes. Mercury is probably not used at all, Numeric can be used due to some artifacts, but since it is not respected by Maven Resolver itself, it makes little sense to keep it.
With the two comparators removed, we can simply use the default comparator that
DefaultArtifactprovides on its own (which is also in line with Resolver implementation ofGenericVersion).The rest is refactoring:
RuleServicefromVersionsHelperto handle rules-related business, e.g. ignored versions;ArtifactFactory;DefaultArtifactVersionCachetoArtifactVersionService;PropertyVersions: moved artifact resolution business toDefaultVersionsHelper;