TEMP: advance mutual-information port after #1316 - #1340
Conversation
* refactor(tests): finish pytest-owned suite architecture * fix(tests): include exhaustive lane in full CI reproduction * fix(ci): avoid full benchmarks for root Makefile changes * fix(ci): release superseded runs before aggregate gates
Refresh #1299 after the pytest-owned test-architecture cut without changing its declaration-owned runtime seam.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a97690771
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: required | ||
| if: ${{ always() }} | ||
| needs: [static, python, boundaries, wheel, coverage, lean, optional-providers] | ||
| if: ${{ always() && !cancelled() }} |
There was a problem hiding this comment.
When the latest PR workflow is cancelled while required dependencies are running, cancelled() becomes true and this condition skips the required job instead of executing the result checks below; the three branch-protection mirror jobs use the same condition and are skipped as well. GitHub permits conditionally skipped required checks to satisfy branch protection, so cancelling the run can bypass the intended fail-closed gates. These small aggregation jobs should retain always() so a cancelled dependency is converted into an explicit failure.
Useful? React with 👍 / 👎.
| # The root Makefile is parsed by the benchmark contract targets, but its | ||
| # product-test targets do not alter host verifier behavior. Harbor-owned | ||
| # execution commands live in make/harbor.mk below. | ||
| "Makefile": (), |
There was a problem hiding this comment.
Classifying the entire root Makefile as an empty control-plane selection suppresses executable host validation for changes that do affect it: the root defines PYTEST_RUNNER and UV_RUN, which make/harbor.mk uses for harbor-execution-check, harbor-validation-tests, and harbor-host-validation, and it owns the include make/harbor.mk statement itself. A PR modifying any of those shared harness pieces now produces run-benchmark-host-validation=false; the static contract job cannot prove that host verifiers still execute correctly. Keep the root Makefile fail-closed or add actual hunk-level ownership before exempting its product-only sections.
Useful? React with 👍 / 👎.
1 participant
Temporary stack synchronization. Merge the latest #1299 base into #1300 only if conflict-free.