-
Notifications
You must be signed in to change notification settings - Fork 9
TEMP: advance mutual-information port after #1316 #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,10 @@ def _discover_conjecture_host_tests() -> tuple[str, ...]: | |
| "benchmarks/validation/test_heldout_bundle.py", | ||
| "benchmarks/validation/test_heldout_runner.py", | ||
| ), | ||
| # The root Makefile is parsed by the benchmark contract targets, but its | ||
| # product-test targets do not alter host verifier behavior. Harbor-owned | ||
| # execution commands live in make/harbor.mk below. | ||
| "Makefile": (), | ||
|
Comment on lines
+56
to
+59
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Classifying the entire root Useful? React with 👍 / 👎. |
||
| "benchmarks/tooling/benchmark_timings.py": ( | ||
| "benchmarks/validation/test_benchmark_timings.py", | ||
| ), | ||
|
|
@@ -92,7 +96,7 @@ def _discover_conjecture_host_tests() -> tuple[str, ...]: | |
| ), | ||
| } | ||
| SHARED_HOST_HARNESS_PATHS = { | ||
| "Makefile", | ||
| "make/harbor.mk", | ||
| "tools/pytest_lifecycle.py", | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the latest PR workflow is cancelled while required dependencies are running,
cancelled()becomes true and this condition skips therequiredjob instead of executing the result checks below; the three branch-protection mirror jobs use the same condition and are skipped as well. GitHub permits conditionally skipped required checks to satisfy branch protection, so cancelling the run can bypass the intended fail-closed gates. These small aggregation jobs should retainalways()so a cancelled dependency is converted into an explicit failure.Useful? React with 👍 / 👎.