Make det queries discover determinant operations - #2024
Conversation
morluto
left a comment
There was a problem hiding this comment.
Review verdict: no correctness blocker found
This is a narrow, appropriate discovery-metadata change. Adding det as a standalone title token makes the existing token-boundary search discover the numeric and symbolic determinant operations without changing either mathematical implementation or public schemas.
The regression checks the user-visible ranking rather than an internal score, which is the right level. One nonblocking concern is brittleness: asserting the exact first two operations couples the test to future catalog additions that may legitimately also be strong det matches. A property-style assertion that both determinant operations precede unrelated matches would preserve the intent with less ranking-order coupling, but the current behavior is coherent.
3ca1ffd to
556c212
Compare
|
Addressed the review observation: the regression now checks that both determinant operations precede both unrelated characteristic-polynomial matches, without fixing the order between legitimate determinant operations. The branch is rebased onto current main and |
Problem
On current
main, the standard mathematical abbreviationdetranks matrix characteristic-polynomial operations first because their descriptions containdet(tI-A). The actual rational and symbolic determinant operations do not mention the abbreviation in their searchable metadata.This is a demonstrated leaf-level vocabulary gap. It follows the maintainer direction recorded on #1059: keep discovery lexical and fix concrete terminology gaps in the owning
MathToolmetadata instead of introducing a new retrieval architecture.Change
detabbreviation to the titles of the rational and symbolic determinant operations.The property-style regression intentionally does not impose an order between the two legitimate determinant operations, addressing the maintainer's review concern about future catalog additions.
This changes discovery metadata only. Request/result models, mathematical implementations, bounds, and execution semantics are unchanged.
Validation
mainafter merged Fix references to the moved agent evaluation guide #2029.make check— 1,309 passed; Ruff, formatting, complexity, mypy, and ordinary owner tests passed.make test-integration TESTS=tests/integration/catalog/test_builtin_examples.py— 239 passed on the original validated tree; the rebase changed only the unrelated moved-guide paths.git diff --check— passed.Scope
This PR intentionally does not change global tokenization or ranking semantics and does not attempt to solve numeric-literal query interpretation.