feat(shell): add configurable SHELL_TIMEOUT environment variable - #15
Merged
Conversation
- Add getTimeout() function to read SHELL_TIMEOUT env var (default: 30s) - Update ExecuteCommand to use getTimeout() instead of hardcoded value - Update tool description to document the new env variable
localai-bot
marked this pull request as ready for review
February 26, 2026 20:59
mudler
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a configurable timeout via the SHELL_TIMEOUT environment variable for shell command execution in the shell MCP server.\n\nThis allows users to set a default timeout for all commands by setting the SHELL_TIMEOUT environment variable (in seconds). The default remains 30 seconds if not set or invalid.\n\nThe timeout can still be overridden per-request using the existing parameter in the tool input.\n\nFixes: The shell MCP needed a configurable timeout via environment variable.