Skip to content

feat(shell): add configurable SHELL_TIMEOUT environment variable #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudler merged 1 commit into from
Feb 26, 2026
Merged

feat(shell): add configurable SHELL_TIMEOUT environment variable #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions shell/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"log"
"os"
"os/exec"
"strconv"
"strings"
"time"

Expand Down Expand Up @@ -43,6 +44,20 @@ func getWorkingDirectory() string {
return os.Getenv("SHELL_WORKING_DIR")
}

// getTimeout returns the default timeout from SHELL_TIMEOUT env var,
// or 30 seconds if not set or invalid
func getTimeout() int {
timeoutStr := os.Getenv("SHELL_TIMEOUT")
if timeoutStr == "" {
return 30
}
timeout, err := strconv.Atoi(timeoutStr)
if err != nil || timeout <= 0 {
return 30
}
return timeout
}

// ExecuteCommand executes a shell script and returns the output
func ExecuteCommand(ctx context.Context, req *mcp.CallToolRequest, input ExecuteCommandInput) (
*mcp.CallToolResult,
Expand All @@ -52,7 +67,7 @@ func ExecuteCommand(ctx context.Context, req *mcp.CallToolRequest, input Execute
// Set default timeout if not provided
timeout := input.Timeout
if timeout <= 0 {
timeout = 30
timeout = getTimeout()
}

// Create a context with timeout
Expand Down Expand Up @@ -146,7 +161,7 @@ func main() {
// Add tool for executing shell scripts
mcp.AddTool(server, &mcp.Tool{
Name: configurableName,
Description: "Execute a shell script and return the output, exit code, and any errors. The shell command can be configured via SHELL_CMD environment variable (default: 'sh -c'). The working directory can be set via SHELL_WORKING_DIR environment variable. An initialization script can be run before server startup via SHELL_INIT_SCRIPT environment variable.",
Description: "Execute a shell script and return the output, exit code, and any errors. The shell command can be configured via SHELL_CMD environment variable (default: 'sh -c'). The working directory can be set via SHELL_WORKING_DIR environment variable. The default timeout can be configured via SHELL_TIMEOUT environment variable (default: 30 seconds). An initialization script can be run before server startup via SHELL_INIT_SCRIPT environment variable.",
}, ExecuteCommand)

// Run the server
Expand Down
Loading