Always calculate suggestions if in add_vector_related step#1993
Open
Always calculate suggestions if in add_vector_related step#1993
Conversation
ajparsons
force-pushed
the
alerts-form-suggestions-tweak
branch
from
d06cb7d to
cfef9f6
Compare
ajparsons
changed the title
Member
|
Is there an issue for this or a copy of the error message I could look at? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bit cautious about this one because I can't reproduce the underlying error (could be a weird form thing), but the issue makes sense I think.
When we get errors from the alerts form, the details we're getting are saying 'shown_related' is true, while in the 'add_vector_related' step (something goes wrong submitting that form, which loops back to the same view, but also tells it it doesn't need to calculate suggestions it needs).
This tweak means we will always recalculate suggestions if in the add_vector_related step.