Skip to content

Always calculate suggestions if in add_vector_related step #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajparsons wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always calculate suggestions if in add_vector_related step #1993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion classes/AlertView/Standard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,11 @@ private function processAction() {
private function processStep() {
# fetch a list of suggested terms. Need this for the define screen so we can filter out the suggested terms
# and not show them if the user goes back
if (in_array($this->data['step'], ['review', 'define', 'add_vector_related']) && !$this->data['shown_related']) {
# if we're looking at the review or define step - and we haven't previously shown suggestions
# we look for them, and if find them, trigger the add_vector_related step
$is_step_add_vector_related = $this->data['step'] == 'add_vector_related';
$not_shown_related_yet = (in_array($this->data['step'], ['review', 'define']) && !$this->data['shown_related']);
if ($is_step_add_vector_related || $not_shown_related_yet) {
$suggestions = [];
foreach ($this->data['keywords'] as $word) {
$terms = $this->alert->get_related_terms($word);
Expand Down
Loading