fix(cli): only show update notice when PyPI version is actually newer#993
Open
berettavexee wants to merge 1 commit into
Open
fix(cli): only show update notice when PyPI version is actually newer#993berettavexee wants to merge 1 commit into
berettavexee wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The update check compares versions with
!=:This means the notice also fires when the installed version is newer than PyPI — e.g. on a dev install, a pre-release, or a fork. Users on
devinstalls see the "please upgrade" message on every run even though they're already ahead of the release.Fix
Compare version tuples numerically so the notice only appears when PyPI actually has a newer release:
The helper also handles malformed version strings gracefully (returns
(0, 0, 0), suppressing the notice).Test plan
🤖 Generated with Claude Code