Skip to content

fix(cli): only show update notice when PyPI version is actually newer #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berettavexee wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(cli): only show update notice when PyPI version is actually newer #993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion streamrip/rip/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,12 @@ async def url(ctx, urls):

if version_coro is not None:
latest_version, notes = await version_coro
if latest_version != __version__:
def _ver(v):
try:
return tuple(map(int, v.split(".")))
except (ValueError, AttributeError):
return (0, 0, 0)
if _ver(latest_version) > _ver(__version__):
console.print(
f"\n[green]A new version of streamrip [cyan]v{latest_version}[/cyan]"
" is available! Run [white][bold]pip3 install streamrip --upgrade[/bold][/white]"
Expand Down