Chore: Abstract and make more canonical for webmcp#8
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors WebMCP tool registration to use a shared, canonical TOOLS registry, so both the WebMCP runtime and the iframe MCP server consume the same tool definitions.
Changes:
- Introduces
public/app/data/tools/index.jsexporting aTOOLSarray and moves the search tool intopublic/app/data/tools/search.js. - Updates WebMCP tool registration (
webmcp.js) to register all tools fromTOOLS. - Updates the iframe MCP server (
iframe-server.js) to list tools fromTOOLSand route tool calls by tool name.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| public/app/data/webmcp.js | Switches from a single hardcoded tool registration to registering all tools in TOOLS. |
| public/app/data/tools/search.js | Converts the prior schema/executor split into a single searchTool object with execute. |
| public/app/data/tools/index.js | Adds the canonical tool registry (TOOLS). |
| public/app/data/iframe-server.js | Lists tools from TOOLS and updates tools/call dispatch logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
public/app/data/tools/index.jsexporting aTOOLSarray and moves the search tool intopublic/app/data/tools/search.js.webmcp.js) to register all tools fromTOOLS.iframe-server.js) to list tools fromTOOLSand route tool calls by tool name.