Expand formatter coverage by anderson4j · Pull Request #675 · neo4j/cypher-language-support

anderson4j · 2026-04-16T15:04:50Z

Things have been busy over the past couple of months, and the formatter has not been kept up to date with recent grammar updates. In addition, it seems like some old syntax like CREATE DATABASE was not covered. This PR is to fix this, updating the formatter and adding test with example syntax.

Closes LS-145

…ix test of vector_norm test, manual addition of createAlias/createDb handling + testing

changeset-bot · 2026-04-16T15:04:59Z

🦋 Changeset detected

Latest commit: f93aec7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@neo4j-cypher/language-support	Patch
@neo4j-cypher/language-server	Patch
@neo4j-cypher/lint-worker	Patch
@neo4j-cypher/query-tools	Patch
@neo4j-cypher/react-codemirror-playground	Patch
@neo4j-cypher/react-codemirror	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

… into fixFormatting

Add handling of showCommandYieldWhere like existing showCommandYield Expand auth rule testing

…e formatting

OskarDamkjaer

Formatting changes good to go, the claude changes would be nice to pair on or take in another PR

OskarDamkjaer · 2026-04-22T06:51:58Z

 *.npmrc
 benchmarks.txt
 .idea/
+.claude/


Git-ignoring this one but commiting CLAUDE.md?

IMO it could be interesting to add some skills/etc to the repo, for new contributors, or for automated code review? Let's discuss later in our 121?

Like we said in 1-2-1 I agree. Will clean up this PR when it's ready for a full review

OskarDamkjaer · 2026-04-22T06:55:34Z

@@ -0,0 +1,109 @@
+# CLAUDE.md


I think a shared claude.md would be a good idea, but I think it'd be nice to collaborate on it. I found some of the best practises from anthropic counter intuitive:

https://code.claude.com/docs/en/best-practices#write-an-effective-claude-md

They say to exclude for example anything Claude can figure out by reading code.

OskarDamkjaer · 2026-04-22T06:57:16Z


  test('show indexes with where and return', () => {
-    const query = `SHOW INDEXES YIELD aaaaaa, aaaaaa, aaaaaa, aaaaaa, aaaaaa
+    const query = `SHOW INDEXES


How did you find the queries we fail to format? I'm thinking it could be nice if we could find them automatically? Perhaps we could extract samples from the main repos tests?

I agree, ive discussed this with some surface people before, and they mentioned some .feature files that often contain queries with new syntax. I've made a card here

anderson4j

Here are some replies to your comments. I still have a few months of changes to the grammar left, so I'll fix that first before a re-review

anderson4j · 2026-04-24T12:39:17Z


  test('show indexes with where and return', () => {
-    const query = `SHOW INDEXES YIELD aaaaaa, aaaaaa, aaaaaa, aaaaaa, aaaaaa
+    const query = `SHOW INDEXES


I agree, ive discussed this with some surface people before, and they mentioned some .feature files that often contain queries with new syntax. I've made a card here

anderson4j · 2026-04-24T12:40:06Z

 *.npmrc
 benchmarks.txt
 .idea/
+.claude/


Like we said in 1-2-1 I agree. Will clean up this PR when it's ready for a full review

anderson4j · 2026-04-24T12:40:35Z

@@ -0,0 +1,109 @@
+# CLAUDE.md


…, both with invalid and valid argument parsing paths. fix spacing in commandstest.

avoid spaces/breaks before LPAREN in allReduce like in functionInvocation. Similar fix to RPAREN handling

… into fixFormatting

anderson4j · 2026-05-07T09:15:21Z

    }
  }

+  _emitResidualErrorNodes = () => {


We already have a check to emit missed error nodes when visiting a terminal node. The one case we missed was when the error node was in the end. This change is to emit the leftover error nodes too.

anderson4j · 2026-05-07T14:25:38Z

To find new syntax we hadn't covered I checked changes to the Cypher25Parser.g4 file in he monorepo.

To then figure how it should be formatted I checked what PRs the changes were for and checked what the canonical syntax looked like for this feature in the corresponding CIPs. I also checked the cypher styling guide for the general formatting rules.

OskarDamkjaer

👍

Initial draft by claude - manual fix for next to have double break, f…

7f9540a

…ix test of vector_norm test, manual addition of createAlias/createDb handling + testing

anderson4j added 6 commits April 17, 2026 11:48

add indent to authrulesetclause like in docs

860cdfa

Merge branch 'main' of https://github.com/neo4j/cypher-language-support…

a07448a

… into fixFormatting

handle forList clause

6c694dd

Add handling of showCommandYieldWhere like existing showCommandYield Expand auth rule testing

clean up visitQueryWithLocalDefinitions, add testing of local callabl…

0ba4ff4

…e formatting

remove local claude files, gitignore .claude

6749dd2

adds changeset

862be46

OskarDamkjaer approved these changes Apr 22, 2026

View reviewed changes

anderson4j commented Apr 24, 2026

View reviewed changes

anderson4j added 10 commits April 28, 2026 14:30

move breakLine and fix indentation of search-clause

e98e886

add handling for allReduceInvalidArguments. Test allReduce formatting…

54e7932

…, both with invalid and valid argument parsing paths. fix spacing in commandstest.

remove uppercasing of vector_distance/vector_norm, rename some tests.

91b5ac1

avoid spaces/breaks before LPAREN in allReduce like in functionInvocation. Similar fix to RPAREN handling

add formatting for graph type

e025db8

fix bug on RETURN ALL

969590a

remove claude.md

426de2c

fix rule that relied on concating label type

0ef5dcf

add handling for when we end on error node

096cf9e

Merge branch 'main' of https://github.com/neo4j/cypher-language-support…

167d3fb

… into fixFormatting

adjust changeset

13992ed

anderson4j commented May 7, 2026

View reviewed changes

anderson4j added 2 commits May 7, 2026 15:38

cleanup and fix from claude review

212105b

remove .claude from gitignore

f93aec7

OskarDamkjaer approved these changes May 11, 2026

View reviewed changes

anderson4j merged commit 0b2d441 into main May 11, 2026
14 checks passed

anderson4j deleted the fixFormatting branch May 11, 2026 15:49

Uh oh!

Conversation

anderson4j commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

OskarDamkjaer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anderson4j left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anderson4j commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OskarDamkjaer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anderson4j commented Apr 16, 2026 •

edited

Loading

changeset-bot Bot commented Apr 16, 2026 •

edited

Loading

anderson4j commented May 7, 2026 •

edited

Loading