-
Notifications
You must be signed in to change notification settings - Fork 18
Expand formatter coverage #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7f9540a
Initial draft by claude - manual fix for next to have double break, f…
anderson4j 860cdfa
add indent to authrulesetclause like in docs
anderson4j a07448a
Merge branch 'main' of https://github.com/neo4j/cypher-language-suppo…
anderson4j 6c694dd
handle forList clause
anderson4j 0ba4ff4
clean up visitQueryWithLocalDefinitions, add testing of local callabl…
anderson4j 6749dd2
remove local claude files, gitignore .claude
anderson4j 862be46
adds changeset
anderson4j e98e886
move breakLine and fix indentation of search-clause
anderson4j 54e7932
add handling for allReduceInvalidArguments. Test allReduce formatting…
anderson4j 91b5ac1
remove uppercasing of vector_distance/vector_norm, rename some tests.
anderson4j e025db8
add formatting for graph type
anderson4j 969590a
fix bug on RETURN ALL
anderson4j 426de2c
remove claude.md
anderson4j 0ef5dcf
fix rule that relied on concating label type
anderson4j 096cf9e
add handling for when we end on error node
anderson4j 167d3fb
Merge branch 'main' of https://github.com/neo4j/cypher-language-suppo…
anderson4j 13992ed
adjust changeset
anderson4j 212105b
cleanup and fix from claude review
anderson4j f93aec7
remove .claude from gitignore
anderson4j File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@neo4j-cypher/language-support": patch | ||
| --- | ||
|
|
||
| Expand formatter coverage to cover SEARCH, GRAPH TYPE and more. Fixes bugs, for example SHOW ... YIELD formatting bug, and failing to format full query when parsing only fails at the end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,5 +18,6 @@ generated | |
| *.npmrc | ||
| benchmarks.txt | ||
| .idea/ | ||
| .claude/ | ||
| vite.config.ts.timestamp* | ||
| .wdio-vscode-service | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git-ignoring this one but commiting CLAUDE.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it could be interesting to add some skills/etc to the repo, for new contributors, or for automated code review? Let's discuss later in our 121?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like we said in 1-2-1 I agree. Will clean up this PR when it's ready for a full review