fix: Preserve baseUrl when writing paths in library tsconfig update#2305
Closed
fix: Preserve baseUrl when writing paths in library tsconfig update#2305
baseUrl when writing paths in library tsconfig update#2305Conversation
12 tasks
Co-authored-by: kamilmysliwiec <23244943+kamilmysliwiec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from PR #2302 for v12.0.0 release
fix: Preserve Mar 11, 2026
baseUrl when writing paths in library tsconfig update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript requires
baseUrlto be set wheneverpathsmappings are used — without it, path aliases are silently ignored. TheupdateTsConfigfunction was deletingbaseUrlwhile still writingpaths, producing an invalid config.Changes
library.factory.ts: Replacedelete tsconfig.compilerOptions.baseUrlwithtsconfig.compilerOptions.baseUrl = './'to ensurepathsmappings are validlibrary.factory.test.ts: Update affected test assertions to expectbaseUrl: "./"rather thanundefinedBefore:
{ "compilerOptions": { "paths": { "app/my-lib": ["./libs/my-lib/src"], "app/my-lib/*": ["./libs/my-lib/src/*"] } } }After:
{ "compilerOptions": { "baseUrl": "./", "paths": { "app/my-lib": ["./libs/my-lib/src"], "app/my-lib/*": ["./libs/my-lib/src/*"] } } }🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.