docs: rename 'Merge Requirements Checklist' to 'Merge Gate'#24
Merged
Conversation
SKILL.md Critical Rule 2 tells readers to 'run the merge gate in references/pull-request-workflow.md' but the reference had no section literally titled 'Merge Gate' — it was called 'Merge Requirements Checklist'. Reviewer flagged the inconsistency on PR #23. Renames the section to 'Merge Gate', retitles the inline check to 'Merge-Gate Command', adds reviewThreads to the gh pr view query and the isResolved-all-true criterion (making the gate behavior match the claude-code-hooks merge-gate.sh script), and cross-links that script for automated enforcement. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the pull request workflow documentation by introducing a "Merge Gate" section, refining the pre-merge checklist, and providing a command to programmatically verify merge readiness. Feedback was provided regarding the gh CLI command syntax, specifically noting that leading spaces in the multi-line JSON field list will cause execution errors and that the reviewThreads property is a direct array rather than being nested under a nodes key.
There was a problem hiding this comment.
Pull request overview
This PR resolves terminology drift in the git-workflow skill docs by renaming the “Merge Requirements Checklist” section to “Merge Gate”, aligning with references from SKILL.md and related hook documentation.
Changes:
- Renamed section heading to
## Merge Gateand updated related subsection naming. - Expanded the
gh pr viewJSON fields to includereviewThreadsand documented merge-ready criteria inline. - Added a cross-reference to the
merge-gate.shenforcement hook recipe inreferences/claude-code-hooks.md.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Four reviewer findings on PR #24: 1. Gemini: '--json' expects a single comma-separated string; the backslash-newline-indent formatting inserted spaces around commas, making 'reviewDecision, mergeStateStatus' get parsed as two args instead of one field list. Flattened to a single line. 2. Gemini: 'gh pr view --json reviewThreads' flattens the GraphQL response — the gh CLI returns reviewThreads as a direct array, not wrapped in {nodes: [...]}. Corrected the jq criterion from '.reviewThreads.nodes[].isResolved' to '.reviewThreads[].isResolved'. 3. Copilot: section said 'runs this same command via a PreToolUse hook and denies gh pr merge calls that don't clear every gate', but the merge-gate.sh script only checks reviewDecision, mergeStateStatus, and unresolved thread count — not statusCheckRollup, annotations, or signed commits. Softened the claim to 'runtime-checkable subset' and explicitly calls out what the hook doesn't cover (annotations require commit-level API, signed commits rely on branch protection). 4. Copilot: 'Single command that surfaces every gate input' wording was misleading because a second command follows for CI annotations. Restructured into a primary PR-level gate + a separate commit-level annotation check, explaining why the split exists. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKILL.md's Critical Rule 2 tells readers to "run the merge gate in `references/pull-request-workflow.md`", but the reference had no section literally titled "Merge Gate" — it was called "Merge Requirements Checklist". Reviewer flagged the inconsistency on PR #23.
Changes
references/pull-request-workflow.md:## Merge Requirements Checklist→## Merge Gate### Check Programmatically→### Merge-Gate CommandWhy
Terminology consistency. The Critical Rules, the hooks reference, and the gate check now all use the same name.
Test plan