feat(refs): bare-worktree layout + signed-commit discipline#26
Merged
Conversation
Capture two recurring team practices that weren't codified in the
existing references:
## Bare-worktree project layout (advanced-git.md)
Netresearch clones every repo as '/projects/<repo>/.bare' + one
subdirectory per branch. Rationale (IDE indexing, parallel feature
work, clean main checkout), full setup command sequence, batch
cleanup pattern for post-session teardown. Based on CLAUDE.md
convention 'Git Worktree Convention'.
## Signed-commit + DCO-signoff discipline (commit-conventions.md)
Promote 'Sign commits (optional)' to a required-practice section:
- 'git commit -S --signoff' always — explicit -S surfaces
signing failures instead of silently shipping unsigned commits
when SSH agent isn't available in subprocess environments.
- --signoff required for DCO compliance on most netresearch repos.
- Signoff identity must match git config user.{name,email}; the
DCO check fails with 'signoff required' (unhelpful) when they
diverge.
- Never --no-verify / --no-gpg-sign as a shortcut around hook
failures. Never 'git commit --amend' after a pre-commit hook
failed — the commit didn't happen, so --amend rewrites the
PREVIOUS commit.
- Atomic commits: one logical change per commit, squash WIP
before PR.
- 'git push -u' on first push of a new branch.
Both sections are cross-referenced from the Best Practices Summary.
Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR updates the shared git-workflow skill references to codify two netresearch Git practices: a bare-repo + multi-worktree project layout and stricter signed-commit + DCO sign-off discipline.
Changes:
- Expand commit guidance to require
git commit -S --signoff, add DCO/signing rationale, and add sections on atomic commits and first-push upstream setup. - Add a “Bare-Worktree Project Layout” section describing a
.bare/+ per-branch folder layout, setup steps, and cleanup workflows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| skills/git-workflow/references/commit-conventions.md | Promotes signing + signoff from optional to required and adds supporting workflow guidance. |
| skills/git-workflow/references/advanced-git.md | Documents the bare repo + per-branch worktree directory convention and lifecycle commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CybotTM
added a commit
that referenced
this pull request
Apr 21, 2026
fix(refs): address Copilot review followups from #26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move two recurring netresearch team practices out of per-user CLAUDE.md files into the shared skill where they belong.
Bare-worktree project layout (
advanced-git.md)Netresearch clones every repo as
/projects/<repo>/.bare+ one subdirectory per branch. Codifies:.bare/+main/+<feature-branch>/)git clone --bare+remote.origin.fetchconfig + first worktree add)for wt in …; do worktree remove + branch -D; done+fetch --prune origin)Signed-commit + DCO-signoff discipline (
commit-conventions.md)Promote
Sign commits (optional)from the Best Practices summary to a full required-practice section:git commit -S --signoffalways. Explicit-Ssurfaces signing failures instead of silently shipping unsigned commits.--signoffrequired for DCO compliance (enabled on most netresearch repos).git config user.{name,email}— mismatched identities fail DCO with an unhelpful "signoff required" message.--no-verify/--no-gpg-signas a shortcut. Nevergit commit --amendafter a pre-commit hook failure (the commit didn't happen; --amend rewrites the PREVIOUS commit).git push -uon first push of a new branch.Test plan