Fetch data directly from pyRAT's api#30
Merged
Merged
Conversation
adamltyson
approved these changes
Apr 13, 2026
adamltyson
left a comment
Member
There was a problem hiding this comment.
All looks sensible to me. My only suggestion would be to refactor in such a way that it's a bit easier to add support for other colony management systems in the future. Something like oscar/colony_management/pyrat?
Collaborator
Author
|
Thanks @adamltyson - good point! I've made that change now, so I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
So far, we have analysed csv files of historical exported data. Ideally, we could fetch this data directly from a pyRAT instance via their REST api.
What does this PR do?
.jsonfiles to the GIN repo). I'm using mock responses so we are never accessing real data or the real pyRAT server during the tests.pooch_data_pathfunction (replacing the previous fixtures for each test dataset), so that any dataset can easily be fetched via name. This reduces the number of lines of code needed to manage this, especially now we have more datasets on GIN.References
Closes #4
How has this PR been tested?
Tests have been added for all new functionality
Is this a breaking change?
No
Does this PR require an update to the documentation?
Relevant docstrings have been updated
Checklist: