Skip to content

Commit 19f8e33

Browse files
authored
Fail closed for AWS approval gates (#3640)
1 parent d30b585 commit 19f8e33

3 files changed

Lines changed: 23 additions & 2 deletions

File tree

.github/workflows/aws_gpu_benchmarks.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ jobs:
112112
with:
113113
ref: ${{ inputs.ref }}
114114
fetch-depth: 0
115+
persist-credentials: false
115116

116117
- name: Install system dependencies
117118
run: |

.github/workflows/pr_target_aws_gpu_benchmarks.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,17 @@ jobs:
9696
needs:
9797
- check-author-membership
9898
- require-approval
99-
if: github.repository == 'newton-physics/newton' && (!cancelled())
99+
if: >-
100+
github.repository == 'newton-physics/newton' &&
101+
!cancelled() &&
102+
needs.check-author-membership.result == 'success' &&
103+
(
104+
needs.require-approval.result == 'success' ||
105+
(
106+
needs.require-approval.result == 'skipped' &&
107+
needs.check-author-membership.outputs.membership_status == 'CONFIRMED_MEMBER'
108+
)
109+
)
100110
uses: ./.github/workflows/aws_gpu_benchmarks.yml
101111
with:
102112
ref: ${{ github.event.pull_request.head.sha }}

.github/workflows/pr_target_aws_gpu_tests.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,17 @@ jobs:
9696
needs:
9797
- check-author-membership
9898
- require-approval
99-
if: github.repository == 'newton-physics/newton' && (!cancelled())
99+
if: >-
100+
github.repository == 'newton-physics/newton' &&
101+
!cancelled() &&
102+
needs.check-author-membership.result == 'success' &&
103+
(
104+
needs.require-approval.result == 'success' ||
105+
(
106+
needs.require-approval.result == 'skipped' &&
107+
needs.check-author-membership.outputs.membership_status == 'CONFIRMED_MEMBER'
108+
)
109+
)
100110
uses: ./.github/workflows/aws_gpu_tests.yml
101111
with:
102112
ref: ${{ github.event.pull_request.head.sha }}

0 commit comments

Comments
 (0)