feat(cron): show command payloads in UI#1286
Merged
Merged
Conversation
clark-cant
approved these changes
Jun 27, 2026
clark-cant
left a comment
clark-cant
left a comment
Contributor
There was a problem hiding this comment.
LGTM — clean follow-up to #1279/#1285. Command payload visibility in the cron UI is well-scoped: proper i18n across all 4 locales, clean utility helpers (isCommandCron, formatCommand), and good conditional rendering between agent-turn and command jobs. CI all green.
Posted by github-maintain at 2026-06-27T04:23:00Z
This was referenced Jun 27, 2026
duhd-vnpay
added a commit
to duhd-vnpay/goclaw
that referenced
this pull request
Jun 30, 2026
…m wiring) 49 commits from upstream beta.27 → beta.67. 709 files / +30861/-1797. NEW UPSTREAM MIGRATIONS (3, schema 103 → 106): - 000085 webhook_calls_heartbeat (lease renewal column + index) - 000086 fix_channel_contacts_merged_fk (FK type fix) - 000087 usage_snapshots_agent_fk (FK constraint + orphan cleanup) LOCAL MIGRATION RENUMBER (19 files shifted +3): - 000085-000103 → 000088-000106 - Affected: cron_jobs_timeout_ms, dropped_harness_workflow_runs, org_users, channel_pairing, departments, dropped_project_*, agents_acp_tools, run_timeline_items, channel_context_capabilities, channel_memory_extraction, secure_cli_agent_credentials, skill_user_grants_tenant_unique, skill_self_evolution, usage_event_analytics, cron_provider_override, add_fk_constraints*, mcp_oauth_tokens. CONFLICT RESOLUTIONS: - internal/upgrade/version.go: RequiredSchemaVersion 103 → 106 - internal/config/config_load.go: upstream + reinsert Keycloak OIDC env block (local fork patch) - internal/store/cron_store.go: upstream (CronCommandSpec + IsCommand) + reinsert TimeoutMS field (local fork.13 patch) - go.mod: max versions per package - whatsmeow: 5f04eac6dbbb (upstream, 06-22 newer) - otel*: v1.43.0 (local) - image: v0.39.0 (local), mod: v0.37.0 (upstream) - oauth2: v0.35.0 (local), term: v0.44.0 (upstream) - sys/net/text/grpc: upstream newer (v0.46/v0.56/v0.38/v1.78) - crypto v0.53.0 / sync v0.21.0 / exp upstream / proto v1.10.0 (local) - go.sum: regenerated via go mod tidy SQLITE (auto-merged): - schema.sql: webhook_calls.last_heartbeat_at column added - schema.go: SchemaVersion 51 → 52 + migration patch added (mirrors PG 000085; 086/087 PG-specific FK fixes not mirrored) UPSTREAM HIGHLIGHTS (49 commits): - fix(cron): invert stateless gate (nextlevelbuilder#1139) — fixes UI label mismatch (eliminates need for local seed 123-cron-stateless-fix.sql; remove next session) - feat(cron): deterministic command payloads (nextlevelbuilder#1279) + UI nextlevelbuilder#1286-1289 — major new feature: cron runs shell command without LLM (zero token cost) - feat(webhooks): lease heartbeat (nextlevelbuilder#1275), configurable timeout (nextlevelbuilder#1267), paginate list (nextlevelbuilder#1268), stream provider responses for caching (nextlevelbuilder#1273) - feat(providers): Ollama native provider (nextlevelbuilder#1307 fixes num_ctx) - feat(i18n): Korean ko locale (nextlevelbuilder#1081) - fix(security): block 198.18.0.0/15 + 240.0.0.0/4 SSRF (nextlevelbuilder#1269) - feat(auth): inherit tenant_users.role for paired sessions (nextlevelbuilder#1066) - feat(telegram): /addcron /removecron /croners commands (nextlevelbuilder#1106) - feat(bitrix24): mention gate, OpenLine media tags (nextlevelbuilder#1294-1296) VERIFY: - go build ./... PASS (PG build) - go build -tags sqliteonly ./... PASS (Desktop/SQLite build) - go vet ./... → 1 pre-existing upstream Windows-only test bug (document_parser_test.go uses waitForRecordedPIDs which is in shell_abort_test.go gated `//go:build !windows`) — non-blocking - Migration sequence: 1 → 106 sequential, 0 gaps, 0 duplicates - Conflict markers: 0 remaining BACKUP: backup-pre-v3.15.0-beta.67-merge Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NgQHyKwxDBedm9KbfFyk3w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to command cron enablement work in #1279 and #1285. Those PRs made deterministic command cron jobs runnable/configurable, but the cron dashboard still rendered them like agent-turn jobs and showed “No message configured”; this adds read-only visibility for command payloads in the UI.
Adds a payload type badge in the cron list and command details in the job overview so operators can see when a cron job runs a script/command.
Type
main)Target Branch
Targets
dev.Checklist
go build ./...passesgo build -tags sqliteonly ./...passes (if Go changes)go vet ./...passesgo test -race ./...cd ui/web && pnpm build(if UI changes)$1, $2(no string concat)internal/upgrade/version.go(if new migration)Test Plan
corepack prepare pnpm@10.30.1 --activate && pnpm --dir ui/web buildenv -u GOCLAW_CONFIG -u GOCLAW_DATA_DIR -u GOCLAW_HOST -u GOCLAW_PORT -u GOCLAW_PUBLIC_URL -u GOCLAW_ALLOWED_ORIGINS PATH=/usr/local/go/bin:$PATH go build ./...env -u GOCLAW_CONFIG -u GOCLAW_DATA_DIR -u GOCLAW_HOST -u GOCLAW_PORT -u GOCLAW_PUBLIC_URL -u GOCLAW_ALLOWED_ORIGINS PATH=/usr/local/go/bin:$PATH go build -tags sqliteonly ./...