fix(release): allow a skipped windows smoke on the stable lane - #6480
Merged
Conversation
release-stable.yml offers win_x64_smoke_mode: skip, but choosing it makes the release impossible to finish. The windows smoke uploads its e2e report with if-no-files-found: warn, so a skipped smoke leaves the report directory empty and publishes no artifact; finalize then downloads that artifact unconditionally and fails — after every platform has already built, signed and notarized, and after the pre-flight tag check has passed. Twenty-five minutes of work is thrown away for a report nothing downstream reads. Guard the download on the same condition that gates the smoke itself, matching how the linux report is guarded by its build result. The mac report stays unconditional because the mac smoke has no skip switch.
Contributor
|
🚫 Direct PRs into release branches are not accepted. Changes reach a release branch through the backport flow, not by targeting
Closing this PR. If this is a genuine release-only fix that cannot go through |
lefarcen
added
size/XS
This was referenced Aug 5, 2026
lefarcen
added a commit
that referenced
this pull request
Aug 5, 2026
Brings back the commits that landed directly on the release branch and exist nowhere else: #6480 (guard the windows e2e report download so win_x64_smoke_mode: skip is usable on the stable lane), #6452 (retry NSIS install and fail the setup step loudly), #6440 and #6437 (release/v0.18.0 auto-build defaults, both scoped by their own github.ref_name conditions), #6435 (the amr_profile input that enables the Workspace Team transport), plus the release-cut chores. apps/packaged/package.json keeps main's 0.16.2 rather than taking the branch's 0.18.0: this repo advances main's version through its own 'chore(release): bump main to X.Y.Z ahead of stable' PRs (#6000, #5661, #5441), never through a back-merge.
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
release-stable.ymlofferswin_x64_smoke_mode: skip, but picking it makes the release impossible to finish — and it fails in the most expensive place possible.The windows smoke uploads its e2e report with
if-no-files-found: warn, so a skipped smoke leaves the report directory empty and publishes no artifact at all. The finalize job then downloads that artifact unconditionally and dies. By that point all three platforms have already built, signed and notarized, and the pre-flight tag check has passed — roughly 25 minutes of work thrown away for a report that nothing downstream reads.Hit while cutting 0.18.0: the P2 windows smoke asserts a fresh install reaches home, which the cloud sign-in onboarding structurally prevents (the sibling P0 case asserts the opposite — that a fresh install shows onboarding).
skipis the documented escape hatch and is exactly what this branch's ownnotify-release-feishuhardcodes, so it needs to actually work.What
Guard the download on the same condition that gates the smoke itself:
This mirrors how the linux report is guarded by its build result. The mac report stays unconditional — the mac smoke has no skip switch.
Validation
${{ inputs.win_x64_smoke_mode != 'skip' }}.31020314879: every platform green,Pre-flight tag/release checkgreen, thenDownload windows e2e spec reportfails with the artifact missing.release-report/winafter the download — the three report downloads have no consumer in that job.Follow-up (not in this PR)
The P2 windows smoke's "must reach home" expectation is stale and contradicts the P0 case. It should be taught about the cloud sign-in shell so Windows regains real smoke coverage instead of living on
skip.Surface area