Skip to content

chore(testing): Add tests for Domain Reconciler#646

Merged
jonstacks merged 4 commits into
ngrok:mainfrom
jonstacks:mocking
May 6, 2025
Merged

chore(testing): Add tests for Domain Reconciler#646
jonstacks merged 4 commits into
ngrok:mainfrom
jonstacks:mocking

chore(domain-controller): Use k8s ptr library for comparison of CNAME…

e8ac626
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded May 6, 2025 in 1s

29.67% (+0.89%) compared to 7b82194

View this Pull Request on Codecov

29.67% (+0.89%) compared to 7b82194

Details

Codecov Report

Attention: Patch coverage is 87.28814% with 15 lines in your changes missing coverage. Please review.

Project coverage is 29.67%. Comparing base (7b82194) to head (e8ac626).

Files with missing lines Patch % Lines
internal/mocks/nmockapi/domain_client.go 79.66% 9 Missing and 3 partials ⚠️
internal/mocks/nmockapi/base_client.go 94.59% 2 Missing ⚠️
api/ingress/v1alpha1/domain_types.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
+ Coverage   28.77%   29.67%   +0.89%     
==========================================
  Files          95       98       +3     
  Lines       15708    15825     +117     
==========================================
+ Hits         4520     4696     +176     
+ Misses      10924    10855      -69     
- Partials      264      274      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov