Skip to content

chore(testing): Add tests for Domain Reconciler#646

Merged
jonstacks merged 4 commits into
ngrok:mainfrom
jonstacks:mocking
May 6, 2025
Merged

chore(testing): Add tests for Domain Reconciler#646
jonstacks merged 4 commits into
ngrok:mainfrom
jonstacks:mocking

chore(domain-controller): Use k8s ptr library for comparison of CNAME…

e8ac626
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch succeeded May 6, 2025 in 0s

87.28% of diff hit (target 28.77%)

View this Pull Request on Codecov

87.28% of diff hit (target 28.77%)

Annotations

Check warning on line 130 in api/ingress/v1alpha1/domain_types.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/ingress/v1alpha1/domain_types.go#L130 

Added line #L130 was not covered by tests

Check warning on line 52 in internal/mocks/nmockapi/base_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/mocks/nmockapi/base_client.go#L51-L52 

Added lines #L51 - L52 were not covered by tests

Check warning on line 75 in internal/mocks/nmockapi/domain_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/mocks/nmockapi/domain_client.go#L71-L75 

Added lines #L71 - L75 were not covered by tests

Check warning on line 79 in internal/mocks/nmockapi/domain_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/mocks/nmockapi/domain_client.go#L78-L79 

Added lines #L78 - L79 were not covered by tests

Check warning on line 100 in internal/mocks/nmockapi/domain_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/mocks/nmockapi/domain_client.go#L99-L100 

Added lines #L99 - L100 were not covered by tests
View more details on Codecov