feat(signals): add Events plugin#4769
Merged
markostanimirovic merged 6 commits intomainfrom May 9, 2025
Merged
Conversation
❌ Deploy Preview for ngrx-site-v19 failed.
|
✅ Deploy Preview for ngrx-io canceled.
|
Member
timdeschryver
left a comment
There was a problem hiding this comment.
This is looking good! 🤘
I left a couple of questions.
To include it to the docs you'll to also have to update the following files:
- projects/ngrx.io/tools/transforms/authors-package/api-package.js
- projects/ngrx.io/tools/transforms/angular-api-package/index.js
rainerhahnekamp
requested changes
May 6, 2025
Contributor
rainerhahnekamp
left a comment
There was a problem hiding this comment.
Super! I've left a few comments.
Some of them may have already been discussed during the RFC, but they only became apparent to me once I started using it.
Member
Author
|
Changes from the last commit:
|
rainerhahnekamp
requested changes
May 7, 2025
Contributor
rainerhahnekamp
left a comment
There was a problem hiding this comment.
Very good, just a minor issue with filenames and jsdoc for event(group) and the bigger one with including methods in withEffects
rainerhahnekamp
approved these changes
May 9, 2025
Contributor
rainerhahnekamp
left a comment
There was a problem hiding this comment.
Wonderful. Good to go 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #4580
What is the new behavior?
Events plugin has been added to the
@ngrx/signalspackage.Does this PR introduce a breaking change?