Improving German Message Localization by JHubi1 · Pull Request #51 · nixrajput/get_time_ago

JHubi1 · 2025-06-27T20:22:57Z

Pull Request Checklist

What does this PR do?

This PR changes the translation for "just now" from "vorhin" to "gerade". While the translation for both seems to be identical, there's a not insignificant shift in meaning in the German language. "Vorhin" is quite a bit further in the past than "gerade". This past could have also been a few hours ago. And because "just now" is really 15 ago at max, this is a change that should be made.

Alternatively, I'd suggest "gerade eben" as an alternative. ~~Not a huge difference, just longer, but maybe a bit easier to understand. If I had to choose, I'd probably rather go with "gerade".~~

"Gerade eben" is better and more consistent with other programs and packages.

Checklist

Code Changes

I have added new features to the package (e.g., custom time thresholds, new languages, etc.)
I have fixed existing issues (e.g., incorrect formatting, performance bottlenecks)
I have improved the overall structure or optimized the codebase

Documentation

Irrelevant for this kind of change.

- [ ] I have updated the README file or relevant documentation with the changes
- [ ] I have added code usage examples or updated existing examples to reflect changes
- [ ] I have updated the package version in the `pubspec.yaml` file

Testing

General Tests

The package correctly formats time differences into human-readable strings
The package supports dynamic updates (e.g., changing locales, thresholds)

Localization

Irrelevant for this kind of change.

- [ ] The package supports all documented languages
- [ ] Custom locales can be added and work as expected
- [ ] Language fallback works correctly if a specific locale is missing

Custom Thresholds

Irrelevant for this kind of change.

- [ ] Custom time thresholds are applied correctly
- [ ] The package handles edge cases like just now, future dates, or extreme past dates

Error Handling

Irrelevant for this kind of change.

- [ ] The package handles null or invalid inputs gracefully
- [ ] Fallback behavior works for unexpected or incorrect configurations

Responsiveness

Irrelevant for this kind of change.

- [ ] The package adapts to time-zone differences accurately
- [ ] The formatting responds correctly to locale changes in the app

Performance

Irrelevant for this kind of change.

- [ ] The package performs efficiently, even when processing frequent or large updates
- [ ] Performance tests show no regressions

How did you verify your code works?

Well, test passes. Also a local run.

Summary by CodeRabbit

Style
- Updated the German language message for events occurring less than 15 seconds ago to display "gerade eben" instead of "vorhin".

coderabbitai · 2025-06-27T20:23:37Z

Walkthrough

The justNow method in the GermanMessages class was updated to return "gerade eben" instead of "vorhin" for time intervals less than 15 seconds. No other logic or public API changes were introduced.

Changes

File(s)	Change Summary
lib/src/messages/languages/de_msg.dart	Updated justNow method to return "gerade eben" instead of "vorhin" for recent times.
test/messages/language/de_msg_test.dart	Modified test case to expect "gerade eben" instead of "vorhin" for justNow(10).

Possibly related PRs

Correction text in zh_tw_msg.dart #50: Updates the justNow method in another language message class for similar localization improvements.

Poem

A hop and a skip, in German we say,
"Gerade eben" now leads the way.
No more "vorhin" for moments just past,
Rabbits love updates that happen so fast!
🐇⏰

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 450ce1d and 8a408b2.

📒 Files selected for processing (1)

test/messages/language/de_msg_test.dart (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

test/messages/language/de_msg_test.dart

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

lib/src/messages/languages/de_msg.dart (1)
16-18: Use “gerade eben” for a slightly more idiomatic rendering
“gerade” works, but many German-speaking users expect the fuller phrase “gerade eben” when a stand-alone word is shown in a timestamp context. It reads a bit more natural while still conveying the same immediacy.
-String justNow(int seconds) => 'gerade';
+String justNow(int seconds) => 'gerade eben';
Feel free to keep the shorter form if UI space is at a premium—this is only a style nitpick.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f535bf and 760b616.

📒 Files selected for processing (1)

lib/src/messages/languages/de_msg.dart (1 hunks)

JHubi1 · 2025-06-27T20:27:12Z

Ykw, now that I thought about it a bit, it's prly better to really translate it to "gerade eben".

JHubi1 · 2025-06-27T21:02:35Z

@coderabbitai review

coderabbitai · 2025-06-27T21:02:41Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

nixrajput

Hi @JHubi1,

Thank you for the PR.

Please fix and update all the test cases related to this change and then resubmit it.
Make sure it passes all test cases successfully and fill PR template properly.

Regards,
Nikhil

JHubi1 · 2025-06-28T08:49:29Z

Hi @nixrajput, fixed it

nixrajput

Hi @JHubi1,

I think you have missed or not added PR template provided in the repo to this PR.

JHubi1 · 2025-06-29T10:02:10Z

@nixrajput I've updated the PR to use the correct template

nixrajput

Merging this PR now...

Thanks!!

Update de_msg.dart

760b616

Update de_msg_test.dart

127dca3

coderabbitai bot reviewed Jun 27, 2025

View reviewed changes

JHubi1 added 2 commits June 27, 2025 22:27

Update de_msg_test.dart

f7a4c1e

Update de_msg.dart

450ce1d

nixrajput requested changes Jun 28, 2025

View reviewed changes

Update de_msg_test.dart

8a408b2

nixrajput requested changes Jun 28, 2025

View reviewed changes

nixrajput approved these changes Jun 29, 2025

View reviewed changes

nixrajput merged commit 5eeaf18 into nixrajput:master Jun 29, 2025
3 checks passed

Uh oh!

Conversation

JHubi1 commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

What does this PR do?

Checklist

Code Changes

Documentation

Testing

How did you verify your code works?

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

JHubi1 commented Jun 27, 2025

Uh oh!

JHubi1 commented Jun 27, 2025

Uh oh!

coderabbitai bot commented Jun 27, 2025

Uh oh!

nixrajput left a comment

Choose a reason for hiding this comment

Uh oh!

JHubi1 commented Jun 28, 2025

Uh oh!

nixrajput left a comment

Choose a reason for hiding this comment

Uh oh!

JHubi1 commented Jun 29, 2025

Uh oh!

nixrajput left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JHubi1 commented Jun 27, 2025 •

edited

Loading

coderabbitai bot commented Jun 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)