Skip to content

Improving German Message Localization #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nixrajput merged 5 commits into from
Jun 29, 2025
Merged

Improving German Message Localization #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
760b616
Update de_msg.dart
JHubi1 Jun 27, 2025
127dca3
Update de_msg_test.dart
JHubi1 Jun 27, 2025
f7a4c1e
Update de_msg_test.dart
JHubi1 Jun 27, 2025
450ce1d
Update de_msg.dart
JHubi1 Jun 27, 2025
8a408b2
Update de_msg_test.dart
JHubi1 Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/messages/languages/de_msg.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class GermanMessages implements Messages {

/// Message when the elapsed time is less than 15 seconds.
@override
String justNow(int seconds) => 'vorhin';
String justNow(int seconds) => 'gerade eben';

/// Message for when the elapsed time is less than a minute.
@override
Expand Down
8 changes: 4 additions & 4 deletions test/messages/language/de_msg_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ void main() {
expect(messages.suffixAgo(), '');
});

test('justNow should return "vorhin"', () {
expect(messages.justNow(10), 'vorhin');
test('justNow should return "gerade eben"', () {
expect(messages.justNow(10), 'gerade eben');
});

test('secsAgo should return correct seconds ago format', () {
Expand Down Expand Up @@ -56,12 +56,12 @@ void main() {
}

group('GetTimeAgo Test with German Locale', () {
test('should return vorhin for time less than 15 seconds', () {
test('should return gerade eben for time less than 15 seconds', () {
final result = GetTimeAgo.parse(
_getRelativeDateTime(const Duration(seconds: 0)),
locale: 'de',
);
expect(result, 'vorhin');
expect(result, 'gerade eben');
});

test('should return correct format for seconds ago', () {
Expand Down