Conversation
Signed-off-by: nscuro <nscuro@protonmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #301 by teaching the NuGet version parser to ignore an initial v/V prefix, which prevents prefixed NuGet versions from falling back to less accurate generic comparison logic elsewhere in the ecosystem.
Changes:
- Strip a leading
vorVbefore NuGet version parsing and preserve the existing empty-version validation. - Add regression tests for parsing and comparing lowercase
v-prefixed NuGet versions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
versatile-core/src/main/java/io/github/nscuro/versatile/version/NugetVersion.java |
Updates NuGet parsing to normalize away a leading v/V prefix before component extraction. |
versatile-core/src/test/java/io/github/nscuro/versatile/version/NugetVersionTest.java |
Adds regression coverage for parsing and comparison of lowercase v-prefixed NuGet versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Niklas <nscuro@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301