Skip to content

Ignore v prefix for NuGet versions #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nscuro merged 2 commits into from
May 4, 2026
Merged

Ignore v prefix for NuGet versions #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67511bd
Ignore v prefix for NuGet versions
nscuro May 4, 2026
c243cac
Potential fix for pull request finding
nscuro May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions versatile-core/src/main/java/io/github/nscuro/versatile/version/NugetVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ public Provider() {

String remaining = versionStr;

if (Character.toLowerCase(remaining.charAt(0)) == 'v') {
remaining = remaining.substring(1);
if (remaining.isEmpty()) {
throw new InvalidVersionException(versionStr, "Version must not be empty");
}
}

final int metaIndex = remaining.indexOf('+');
if (metaIndex >= 0) {
this.metadata = remaining.substring(metaIndex + 1);
Expand Down
15 changes: 15 additions & 0 deletions versatile-core/src/test/java/io/github/nscuro/versatile/version/NugetVersionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,21 @@ void testParseLeadingZeros() {
assertThat(version.toString()).isEqualTo("1.0.1");
}

@Test
void testParseWithVPrefix() {
// https://github.com/nscuro/versatile/issues/301
final var version = new NugetVersion("v8.0.0");
assertThat(version.toString()).isEqualTo("8.0.0");
assertThat(version.isStable()).isTrue();
}

@Test
void testCompareWithVPrefix() {
// https://github.com/nscuro/versatile/issues/301
assertThat(new NugetVersion("v4.0.0")).isLessThan(new NugetVersion("8.0.0"));
assertThat(new NugetVersion("v8.0.0")).isEqualTo(new NugetVersion("8.0.0"));
}

@Test
void testParseRealWorldPreview() {
final var version = new NugetVersion("9.0.0-preview.1.24080.9");
Expand Down