[OpenLineageDao] creating cache in code for sources to prevent upsert…#59
Merged
Conversation
lmassaoy
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a caching mechanism for
SourceRowobjects in theOpenLineageDaoto reduce redundant database upserts and improve performance. The main change is the addition of an in-memory cache and refactoring of the dataset upsert logic to utilize this cache. Below are the most important changes grouped by theme:Performance Optimization
SOURCE_ROW_CACHEto theOpenLineageDaointerface to store and reuseSourceRowobjects, minimizing repeated upsert operations for sources with the same name.Code Refactoring
upsertLineageDatasetto use a new private helper methodgetOrUpsertSource, which checks the cache before performing an upsert and stores new sources in the cache. This replaces the previous logic that always performed a database upsert.Imports
HashMapimport to support the new caching mechanism.