Skip to content

[OpenLineageDao] creating cache in code for sources to prevent upsert… #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmassaoy merged 2 commits into from
Aug 13, 2025
Merged

[OpenLineageDao] creating cache in code for sources to prevent upsert… #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa60634
[OpenLineageDao] creating cache in code for sources to prevent upsert…
jrosend Aug 13, 2025
9f78ead
[OpenLineageDao] preventing sourceName from being null
jrosend Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 39 additions & 15 deletions api/src/main/java/marquez/db/OpenLineageDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import java.time.ZonedDateTime;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.LinkedHashMap;
import java.util.List;
Expand Down Expand Up @@ -81,6 +82,9 @@
public interface OpenLineageDao extends BaseDao {
String DEFAULT_SOURCE_NAME = "default";
String DEFAULT_NAMESPACE_OWNER = "anonymous";
Map<String, SourceRow> SOURCE_ROW_CACHE = new HashMap<>();



enum SpecEventType {
RUN_EVENT,
Expand Down Expand Up @@ -835,28 +839,48 @@ default String formatNamespaceName(String namespace) {
return namespace.replaceAll("[^a-z:/A-Z0-9\\-_.@+]", "_");
}

/**
* Returns the {@link SourceType} for the given {@link Dataset}.
* At Nubank we have no use for the SourceType for now.
* The source of all datasets will always be default.
* We might have memory issues with this approach if this changes in the future.
* @param sourceDao DAO for the source table
* @param ds dataset object
* @param now instant
* @return SourceRow
*/
private SourceRow getOrUpsertSource(SourceDao sourceDao, Dataset ds, Instant now) {
String sourceName = DEFAULT_SOURCE_NAME;
String sourceUri = "";
if (ds.getFacets() != null && ds.getFacets().getDataSource() != null) {
sourceName = ds.getFacets().getDataSource().getName() == null ?
DEFAULT_SOURCE_NAME :
ds.getFacets().getDataSource().getName();
sourceUri = getUrlOrNull(ds.getFacets().getDataSource().getUri());
}

SourceRow source = SOURCE_ROW_CACHE.get(sourceName);
if (source == null) {
source = sourceDao
.upsert(
UUID.randomUUID(),
getSourceType(ds),
now,
sourceName,
sourceUri);
SOURCE_ROW_CACHE.put(sourceName, source);
}
return source;
}

default DatasetRecord upsertLineageDataset(
ModelDaos daos, Dataset ds, Instant now, UUID runUuid, boolean isInput) {
daos.initBaseDao(this);
NamespaceRow dsNamespace =
daos.getNamespaceDao()
.upsertNamespaceRow(UUID.randomUUID(), now, ds.getNamespace(), DEFAULT_NAMESPACE_OWNER);

SourceRow source;
if (ds.getFacets() != null && ds.getFacets().getDataSource() != null) {
source =
daos.getSourceDao()
.upsert(
UUID.randomUUID(),
getSourceType(ds),
now,
ds.getFacets().getDataSource().getName(),
getUrlOrNull(ds.getFacets().getDataSource().getUri()));
} else {
source =
daos.getSourceDao()
.upsertOrDefault(UUID.randomUUID(), getSourceType(ds), now, DEFAULT_SOURCE_NAME, "");
}
SourceRow source = getOrUpsertSource(daos.getSourceDao(), ds, now);

String dsDescription = null;
if (ds.getFacets() != null && ds.getFacets().getDocumentation() != null) {
Expand Down
Loading